Subscribe to topic notify-next #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvp1703
force-pushed
the
subscribe-notify-next
branch
from
6c2a333 to
4222f9d
Compare
ActoryOu
previously approved these changes
Jul 30, 2025
ActoryOu
reviewed
Jul 30, 2025
Comment on lines
1396
to
1397
| char jobNotifyTopic[ JOBS_API_MAX_LENGTH( strlen( otademoconfigCLIENT_IDENTIFIER ) ) ]; | ||
| size_t jobNotifyTopicLen = 0; |
There was a problem hiding this comment.
nit: Could you help move these variable declarations to the beginning of function to maintain the coding style?
kvp1703
force-pushed
the
subscribe-notify-next
branch
from
4222f9d to
b6639a5
Compare
kvp1703
force-pushed
the
subscribe-notify-next
branch
from
b6639a5 to
2d44c9a
Compare
aggarg
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add subscription to notify-next topic for OTA job pickup
Description
This change re-introduces the subscription to the
notify-nexttopic. In a previous re-structuring, this essential topic subscription was inadvertently removed. This topic is crucial for the device to be notified of and pick up new OTA jobs that are created after the device has already connected to the AWS IoT Core. Without this subscription, new OTA jobs initiated post-connection were not being detected by the device.Test Steps
Checklist:
Related Issue
Issue 117
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.