Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add video batch selection mode #4198

Open
wants to merge 41 commits into
base: development
Choose a base branch
from
Open

Add video batch selection mode #4198

wants to merge 41 commits into from

Commits on Sep 10, 2023

  1. Implement base styling for top nav buttons and label

    @kommunarr
    kommunarr committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    90eb014 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Refactor video dropdown options and event handling to be utility func… 

    …tions
    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1f7e689 View commit details
    Browse the repository at this point in the history

  2. Separate history-add and history-remove actions

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9194e03 View commit details
    Browse the repository at this point in the history

  3. Implement selected objects being stored in Vuex state

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    68c4d11 View commit details
    Browse the repository at this point in the history

  4. Add plural labels & top nav select mode state variable integration

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7558f62 View commit details
    Browse the repository at this point in the history

  5. Implement & update ft-list-video selectMode state update & dropdown l… 

    …ogic
    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    98ad330 View commit details
    Browse the repository at this point in the history

  6. Update favorites icon watch styling with select mode enabled

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    45abc20 View commit details
    Browse the repository at this point in the history

  7. Update Select Mode to include save/unsave and count

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    be8fb08 View commit details
    Browse the repository at this point in the history

  8. Include count in most labels when possible

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    13d4b96 View commit details
    Browse the repository at this point in the history

  9. Update label and add back ft-video-list needed functions

    @kommunarr
    kommunarr committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    356e038 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Implement Select Mode set to disabled on route change

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1e47a00 View commit details
    Browse the repository at this point in the history

  2. Update additional video dropdown labels to include count

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    78f9aeb View commit details
    Browse the repository at this point in the history

  3. Update certain toasts to use

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    76d5020 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4790d42 View commit details
    Browse the repository at this point in the history

  5. Implement settings navIcon styling improvement

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3d7d888 View commit details
    Browse the repository at this point in the history

  6. Fix selection addition/removal logic

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b1cfb74 View commit details
    Browse the repository at this point in the history

  7. Put .stop modifier on FtIconButton click/keydown events

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2bfd207 View commit details
    Browse the repository at this point in the history

  8. Implement selected video styling

    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5ddf7f5 View commit details
    Browse the repository at this point in the history

  9. Update logic determining whether to display video is selected or not … 

    …to be fully accurate
    @kommunarr
    kommunarr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    36f847d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    87010b9 View commit details
    Browse the repository at this point in the history

  2. Remove videos from selection onDestroy

    @kommunarr
    kommunarr committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f449a19 View commit details
    Browse the repository at this point in the history

  3. Refactor away isSelectedInSelectMode value to prevent negative count bug

    @kommunarr
    kommunarr committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a815284 View commit details
    Browse the repository at this point in the history

  4. Implement ctrl+A behavior for videos in Select Mode 

    We will need to think about what to do for lazy loading. Probably add a click/etc handler that checks if highlight-interrupting event was made at any point.
    @kommunarr
    kommunarr committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ff316eb View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4ba6d0d View commit details
    Browse the repository at this point in the history

  2. Refactor counts to be stored outside of utils class

    @kommunarr
    kommunarr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7b40fec View commit details
    Browse the repository at this point in the history

  3. Disable element selection when Select Mode is enabled 

    This prevents titles/thumbnails/etc. being selected when Ctrl+A is pressed in Select Mode.
    @kommunarr
    kommunarr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5bb15e9 View commit details
    Browse the repository at this point in the history

  4. De-selects all after Ctrl+A is pressed in Select Mode

    @kommunarr
    kommunarr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    35ddf5f View commit details
    Browse the repository at this point in the history

  5. Implement safeguard on Vue very rarely not updating styling on 1-2 vi… 

    …deos when 'Clear selections' button is pressed with many videos
    @kommunarr
    kommunarr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ad9f9ec View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Implement mouse dragging selection for making multiple selections easier 

    While the more conventional 'highlighting' behavior could be argued for, this would be more awkward while we don't actually have a visible selection rectangle. This dragging behavior is a decent compromise.
    @kommunarr
    kommunarr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    047ff72 View commit details
    Browse the repository at this point in the history

  2. Standardize labels to use 'Selection Mode' verbiage

    @kommunarr
    kommunarr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    a32c685 View commit details
    Browse the repository at this point in the history

  3. Updates labels to be 'Video Selection Mode' while only video selectio… 

    …n is implemented'
    @kommunarr
    kommunarr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2f8fe7f View commit details
    Browse the repository at this point in the history

  4. Implement missing 'More Options' label & adjust new dropdown-position

    @kommunarr
    kommunarr committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2b23046 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    29f272d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Institute cap of 15 on videos that can be opened at once

    @kommunarr
    kommunarr committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5b13d8d View commit details
    Browse the repository at this point in the history

  2. Prevent ft-icon-button dropdown mousedown events from bubbling up 

    This fixes selections on an ft-icon-button dropdown from affecting the parent, which was causing a bug wherein choosing a selection from the dropdown removed/added that video as a selection in Selection Mode.
    @kommunarr
    kommunarr committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b0d40b7 View commit details
    Browse the repository at this point in the history

  3. Update selectionModeSelections data object to be reactive

    @kommunarr
    kommunarr committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f9a73e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Implement select mode enabled styling

    @kommunarr
    kommunarr committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    02da93d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Implement functional channel hiding/unhiding on Selection Mode dropdown

    @kommunarr
    kommunarr committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b6a3dd3 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    74f14ea View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe… 

    …at/add-select-mode
    @kommunarr
    kommunarr committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    24e2887 View commit details
    Browse the repository at this point in the history

  2. Resolve 'locale name' label issue

    @kommunarr
    kommunarr committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    509da87 View commit details
    Browse the repository at this point in the history