reset selected filters after search

[ankitchauhan-aka]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #1693

Description

Testing

1. Apply filters, You must have a red border that shows filter(s) are selected
2. Then search for a term in the search box and choose any option from autosuggestion dropdown
3. After selecting autosuggested options, Filters must be reset to default options.
4. The red border from the filter icon will be removed

[PikachuEXE]

I tested with these steps and failed

• Enter something, enter search result via enter/search button
• Change filter options
• Press search button again
• Search result not updated but filter reset

[ankitchauhan-aka]

I tested with these steps and failed

• Enter something, enter search result via enter/search button
• Change filter options
• Press search button again
• Search result not updated but filter reset

@PikachuEXE I'm attaching a test video with the mentioned steps and cannot replicate the issue. Please share similar so I can fix it ASAP and the same happens in YouTube (as I feel we're taking references from there). Like even if we hit search for the same query it resets the filter.

Not sure, If we've a different requirement here.

Screen.Recording.2024-04-29.at.10.09.26.AM.mov

[PikachuEXE]

Screen.Recording.2024-04-29.at.13.33.20.mov

[ankitchauhan-aka]

@PikachuEXE I've implemented a check, not to reset filter for the same query.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Filter not applied when:

1. Application starts
2. apply labels
3. enter query
4. hit search

VirtualBoxVM_E7hDKoPbOO.mp4

[ankitchauhan-aka]

Filter not applied when:

1. Application starts
2. apply labels
3. enter query
4. hit search

VirtualBoxVM_E7hDKoPbOO.mp4

Fixed.

Thanks for the review.

[PikachuEXE]

It reset filters under strange conditions (e.g. like changing filter below

Screen.Recording.2024-04-30.at.14.24.09.mov

Probably like

• Search A
• Enter B
• Try to set multiple criteria

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PikachuEXE this is not a bug but intended behavior. There is how YT also behaves. In your example Time Today resets because you clicked on Type Channel. Time is based on upload date. A channel cant have a upload date.

[PikachuEXE]

OK there are several issue discovered during testing but not introduced by this PR

[efb4f5ff-1298-471a-8973-3d47447115dc]

Issue?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[efb4f5ff-1298-471a-8973-3d47447115dc]

when u just go to another page lets say most popular the filter also clears.

Taken from the linked issue. This also needs to be implemented.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ankitchauhan-aka]

when u just go to another page lets say most popular the filter also clears.

Taken from the linked issue. This also needs to be implemented.

Fixed.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Route is changed, Filters applied correctly but Filter icon isnt active

VirtualBoxVM_WAzjQZgyTo.mp4

[kommunarr]

@efb4f5ff-1298-471a-8973-3d47447115dc Isn't that the expected behavior? See my earlier comment:

Before moving forward with this, I'd also like some discussion on the intended behavior. We're showing the filter as active after a search is made, until the user submits another query. That's not intuitive, as we shouldn't be showing the filter as if it's active if it isn't going to be. The main reason YT has this behavior the way it is is because changing a filter setting automatically re-submits the same search query but with the new filter. If we do want this feature, the filters should show as clear immediately after the search processes.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Oof i missed that. Will retest soon.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@jasonhenriquez this seems not intuitive to me but please correct me if im wrong. Now the user needs to remember what filter they applied if they want to refine their search more:

1. Apply filter
2. Input search query
3. Hit search
4. Filters reset
5. User has to apply the same filter(s) again + they like to add to refine their search results.

User has to remember what filters they applied in their previous search. That seems like a headache to me.

VirtualBoxVM_wY83QlEB86.mp4

[kommunarr]

That's a tradeoff that I don't know if we can mitigate. The whole difficulty of this feature is that you can't make the same search twice with the same filters as easily.

[ankitchauhan-aka]

@jasonhenriquez so what's next step about this?

[kommunarr]

Unless there are other potential mitigations that I'm missing, the main options are that we go ahead with the feature or don't. I think there is more upside than not to go ahead with the feature.

[ankitchauhan-aka]

I think we should keep the filters selected until the user is changing search query.

[kommunarr]

If I'm understanding correctly, that means showing it as active for the next search, even if it won't be, unless the user then changes the filter to something else, in which case it will be? That seems a bit confusing if so.

[ankitchauhan-aka]

What if it clears filter only if user types different search query,
And if he refines filter then type for new search query filters will be applied

[kommunarr]

If you can get the filter to show as non-active to the user unless they re-open the search filter modal, I'm fine with that. I would also be fine with "have the filters be forgotten unless the user opts to open the modal after a search." I just get the sense that we're trying to emulate YT's behavior here somewhat, which doesn't work exactly, since our filter button is omnipresent, and our current behavior is different.

I'm also wondering if maybe this is getting too complicated / potentially confusing to users, and maybe we should just have a one-click button that removes all active search filters instead.