-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature: Silence skip #7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Feature: Silence skip #7797
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the locale files. Only keep en-us
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
Im a bit confused by this skip rate. Please elaborate why you chose for 2.5x instead of e.g. 10x Lets say the ending of a certain video is 60sec it will take 24sec to skip the silence. Thats way too long imo. Why not detect when there is no audio and detect when audio is playing again and instantly skip towards that timestamp instead of relying on playback rate to handle this |
The main goal of this feature is to skip (accelerate) silence between conversations, or other silent parts, not to fast forward to the end of a video. I'm not sure how to "detect when there is no audio and detect when audio is playing again and instantly skip towards that timestamp" . |
|
This implementation works really well, especially considering that our player is the limiting factor in this case. |
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to be a button for this inside the player instead of outside the player
Head branch was pushed to by a user without write access
src/renderer/components/ft-shaka-video-player/player-components/SkipSilenceButton.js
Outdated
Show resolved
Hide resolved
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If i enable this feature my playback rate defaults to 1x and i cant change it
VirtualBoxVM_lekL1aY4w6.mp4
VirtualBoxVM_o0oKzNZISX.mp4
- O and P keyboard shortcuts are used to increase or decrease playback speed but because of the lock to 1x its behaving in weird ways
VirtualBoxVM_46UwulCyhb.mp4
- Discussion point: What should we do about people that are using a playback speed above 3x? I mean if i use 4x to watch a video and silent parts kicks in it probably shouldnt touch the playback speed right?
If i use my left/right arrow keys to skip forward/backward it sometimes skips 2,5x because the skip entered a silence bit. I think thats undesired behavior as it skipped 12,5seconds. The creator wasnt silent for 12,5sec. Context: Arrow Left/Right, Fast-Forward X seconds based on the Fast-Forward Interval and current Video Playback Rate (Ex: 5 seconds Fast-Forward Interval and Video Playback Rate 2x, fast-forwards video 10 seconds)
- Other shortcuts are also affected by this: J and L
…s/SkipSilenceButton.js Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
Head branch was pushed to by a user without write access
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
Umm i think this isnt supposed to happen. It default to 10x now VirtualBoxVM_g9v0U7dPlB.mp4
I think we probably should implement not touching the playback speed if its above 3x |
…feature/skip-silence
|
@efb4f5ff-1298-471a-8973-3d47447115dc I used the user setting values for the fast and normal playback speed. I tested multiple values with various videos and it worked fine even with 10x forward speed. So in your case it's at 10x speed because this should also be your "Max Video Playback Rate"? Do you have problems with speeds above 3x ? I can't unmute in your provided video examples. Are they recorded with sound? |
The arent recorded with sound but i think this case doesnt apply anymore because of the change you explained
Yes it is 10x. I will reevaluate! |


Pull Request Type
Related issue
closes #1766
Description
This PR implements a simple silence skip logic, to dynamically determine silent video parts, related to the individual max volume of the audio source.
Screenshots
2025-10-14.21-02-12.1.mp4
Testing
Desktop
Additional context