Update next video countdown toast to be refreshed per second instead of using workaround #8103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of using workaround
github-actions
bot
added
the
PR: waiting for review
|
hmm maybe i'm interpreting this wrong but doesnt this kind of addresses #2340? It doesnt fade anymore so i think that can be closed |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Oct 7, 2025
|
Updated description for #2340 |
absidue
reviewed
Oct 7, 2025
| interval: 0, | ||
| id: idCounter++ | ||
| } | ||
| time = time || 3000 |
There was a problem hiding this comment.
Suggested change
| time = time || 3000 | |
| time ||= 3000 |
|
Updated |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Oct 8, 2025
|
Sorry I missed it justing my first review, could you please also update the |
|
I introduced |
absidue
approved these changes
Oct 8, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 8, 2025
kommunarr
approved these changes
Oct 10, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 11, 2025
* development: Update next video countdown toast to be refreshed per second instead of using workaround (FreeTubeApp#8103) Remove unused supportsYtdlProtocol from the external player map file (FreeTubeApp#8107) Translated using Weblate (Dutch) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Hide Proxy password (FreeTubeApp#8102) # Conflicts: # src/renderer/components/FtToast/FtToast.vue
|
@PikachuEXE There is a bug in the autoplay logic. Autoplay toast counts down while next video is already loading if countdown is set to 0 in the Player settings. VirtualBoxVM_b3JKT7jfnQ.mp4 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Extracted from #8047 (except the update of
Playing Next Video IntervalpartIf this is merged before #8094, that PR requires a minor fix, if reversed, this PR should be updated
Closes #2340
Description
Count down message (e.g. Playing next video in N seconds) currently implement as series of toasts shown 700ms (per 1s)
This PR just make the toast show for N seconds and update message every second (hardcoded to be 1s as no use case requires otherwise)
Screenshots
Lazy, test yourself :)
Testing
Desktop
Additional context