Skip to content

Change containing text input limit #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2025
Merged

Change containing text input limit #8174

merged 5 commits into from
Nov 1, 2025

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 22, 2025 •
edited
Loading

Pull Request Type

  • Feature Implementation?

Related issue

Closes #8157
#4202

Description

Input limit of 3 was set in the PR that introduced this feature. It was an arbitrary limit and now someone raised an issue because their usecase is to block one specific character. This PR changes the arbitrary limit to 1.

Screenshots

Before:
FreeTube_IyG1SyfkYZ

After:
VirtualBoxVM_w3Yc9Z2UOD

Testing

  1. Go to Settings -> Distraction Free -> General -> Hide Videos and Playlists containing text
  2. Input anything below the below/above the removed limit
  3. Check if content is still being blocked

Desktop

  • OS: Windows 11
  • OS Version: 24H2

Additional context

This limit was introduced in these specific commits:

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 22, 2025 16:24
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 22, 2025
absidue
absidue reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it yet, but based on the code, you could type in multiple spaces and click save/press enter, it would get saved as an empty string and then all videos would be hidden. So we should probably still check that that trimmed input is at least 1 character.

PikachuEXE
PikachuEXE requested changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ya forgot to test space
It will add empty text entry (no matter how many spaces entered)

Image

@absidue
Copy link
Member

absidue commented Oct 23, 2025 •
edited
Loading

Just to be clear, I still think we should trim the input as we do now, but we shouldn't allow the user to add empty filters.

PikachuEXE
PikachuEXE reviewed Oct 23, 2025
View reviewed changes
PikachuEXE
PikachuEXE reviewed Oct 24, 2025
View reviewed changes
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc changed the title Remove containing text input limit Change containing text input limit Oct 25, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 30, 2025

@ChunkyProgrammer @kommunarr

@FreeTubeBot FreeTubeBot merged commit eacc5ce into FreeTubeApp:development Nov 1, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 1, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the remove-containing-text-input-limit branch November 1, 2025 15:51
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 3, 2025
@PikachuEXE
Merge branch 'development' into feature/windows/settings-in-same-folder
f07afab 
* development: (325 commits)
  Replace vue-portal dependency with Vue's built-in <Teleport> component (FreeTubeApp#8207)
  Update to Vue 3 (FreeTubeApp#8094)
  Translated using Weblate (Basque)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Turkish)
  Properly fix CORS in PO token web views (FreeTubeApp#8203)
  Translated using Weblate (Italian)
  Translated using Weblate (Norwegian Bokmål)
  Translated using Weblate (French)
  Configure nedb to always clean up corrupted data (FreeTubeApp#8202)
  Translated using Weblate (Portuguese (Brazil))
  Add video paused check to frame shortcuts (FreeTubeApp#8200)
  Fix toast with timeout 0 will be displayed for default 3s (FreeTubeApp#8168)
  Translated using Weblate (Chinese (Simplified Han script))
  Change containing text input limit (FreeTubeApp#8174)
  Translated using Weblate (Dutch)
  Add support for AppImageUpdate (FreeTubeApp#8153)
  Added New Window option to Tray (FreeTubeApp#7995)
  Translated using Weblate (Japanese)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 3, 2025
@PikachuEXE
Merge branch 'development' into sabr-pr
2d22a9a 
* development: (21 commits)
  Replace vue-portal dependency with Vue's built-in <Teleport> component (FreeTubeApp#8207)
  Update to Vue 3 (FreeTubeApp#8094)
  Translated using Weblate (Basque)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Turkish)
  Properly fix CORS in PO token web views (FreeTubeApp#8203)
  Translated using Weblate (Italian)
  Translated using Weblate (Norwegian Bokmål)
  Translated using Weblate (French)
  Configure nedb to always clean up corrupted data (FreeTubeApp#8202)
  Translated using Weblate (Portuguese (Brazil))
  Add video paused check to frame shortcuts (FreeTubeApp#8200)
  Fix toast with timeout 0 will be displayed for default 3s (FreeTubeApp#8168)
  Translated using Weblate (Chinese (Simplified Han script))
  Change containing text input limit (FreeTubeApp#8174)
  Translated using Weblate (Dutch)
  Add support for AppImageUpdate (FreeTubeApp#8153)
  Added New Window option to Tray (FreeTubeApp#7995)
  Translated using Weblate (Japanese)
  ...
PikachuEXE added a commit to NishPatel101/FreeTube that referenced this pull request Nov 3, 2025
@PikachuEXE
Merge branch 'development' into feat/clickable-playlist-progressbar
9459e23 
* development: (38 commits)
  Replace vue-portal dependency with Vue's built-in <Teleport> component (FreeTubeApp#8207)
  Update to Vue 3 (FreeTubeApp#8094)
  Translated using Weblate (Basque)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Turkish)
  Properly fix CORS in PO token web views (FreeTubeApp#8203)
  Translated using Weblate (Italian)
  Translated using Weblate (Norwegian Bokmål)
  Translated using Weblate (French)
  Configure nedb to always clean up corrupted data (FreeTubeApp#8202)
  Translated using Weblate (Portuguese (Brazil))
  Add video paused check to frame shortcuts (FreeTubeApp#8200)
  Fix toast with timeout 0 will be displayed for default 3s (FreeTubeApp#8168)
  Translated using Weblate (Chinese (Simplified Han script))
  Change containing text input limit (FreeTubeApp#8174)
  Translated using Weblate (Dutch)
  Add support for AppImageUpdate (FreeTubeApp#8153)
  Added New Window option to Tray (FreeTubeApp#7995)
  Translated using Weblate (Japanese)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr kommunarr approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Remove input limit of 3 on title blacklist feature

5 participants

@efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE @kommunarr @FreeTubeBot