Skip to content

Fix behavior of skip frame shortcuts #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
+6 −4
Merged

Fix behavior of skip frame shortcuts #8200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,16 +2287,18 @@ export default defineComponent({
}
case KeyboardShortcuts.VIDEO_PLAYER.PLAYBACK.LAST_FRAME:
// `⌘+,` is for settings in MacOS
if (!event.metaKey) {
if (!event.metaKey && video_.paused) {
event.preventDefault()
// Return to previous frame
frameByFrame(-1)
}
break
case KeyboardShortcuts.VIDEO_PLAYER.PLAYBACK.NEXT_FRAME:
event.preventDefault()
// Advance to next frame
frameByFrame(1)
if (video_.paused) {
event.preventDefault()
// Advance to next frame
frameByFrame(1)
}
break
case KeyboardShortcuts.VIDEO_PLAYER.GENERAL.STATS:
// Toggle stats display
Expand Down