Feature/daniele/checkout custom parameters #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieleAlessandra
force-pushed
the
feature/daniele/checkout-custom-parameters
branch
from
6ab27a1 to
b394995
Compare
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
| protected $_checkout_config = []; | ||
|
|
||
| /** | ||
|
|
There was a problem hiding this comment.
@DanieleAlessandra An extra line.
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| protected function validate_checkout_config($config) |
There was a problem hiding this comment.
@DanieleAlessandra Missing spaces around $config.
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
|
|
||
| $result = array(); | ||
|
|
||
| foreach ($schema as $key => $expected_type) |
There was a problem hiding this comment.
@DanieleAlessandra Please check the spaces.
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
|
|
||
| foreach ($schema as $key => $expected_type) | ||
| { | ||
| if (array_key_exists($key, $config)) |
There was a problem hiding this comment.
@DanieleAlessandra Spaces
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
| switch ($type) | ||
| { | ||
| case 'bool': | ||
| if (is_bool($value)) |
There was a problem hiding this comment.
@DanieleAlessandra Curly braces
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
| * @return array | ||
| */ | ||
| public function get_checkout_config() | ||
| { |
There was a problem hiding this comment.
@DanieleAlessandra Curly braces :)
fajardoleo
reviewed
Oct 3, 2025
includes/class-freemius.php
Outdated
| // cart | ||
| 'always_show_renewals_amount' => 'bool', | ||
| 'annual_discount' => 'bool', | ||
| 'billing_cycle' => ['string', 'int'], |
There was a problem hiding this comment.
@DanieleAlessandra Please check this out:
https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#declaring-arrays
Long array syntax.
Introduce a namespaced filter to let developers add/modify query params sent to Freemius Checkout. • Add fs_apply_filter( $fs->get_unique_affix(), 'checkout_query_params', ... )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for additional checkout configuration properties in the SDK initializer.
What’s new
The following properties are now recognized during initialization:
Behavior
• If these properties exist in the initialization config, they are validated and stored.
• When opening the checkout (both iframe and redirect modes), the provided values are automatically passed along to the checkout context.
This allows developers to customize the checkout flow appearance and cart behavior more flexibly directly from the SDK initialization.