Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imx8mm-ddr4-evk.conf #2029

Closed
wants to merge 1 commit into from

Conversation

vlaarco
Copy link

@vlaarco vlaarco commented Nov 12, 2024

When changing LPDDR4 to DDR4 in imx8mmevk.conf the build fails.

For example:

MACHINEOVERRIDES =. "imx8mm-lpddr4-evk:"
require conf/machine/imx8mm-lpddr4-evk.conf

to

MACHINEOVERRIDES =. "imx8mm-ddr4-evk:"
require conf/machine/imx8mm-ddr4-evk.conf

When changing LPDDR4 to DDR4 in imx8mmevk.conf the build fails.

For example:

MACHINEOVERRIDES =. "imx8mm-lpddr4-evk:"
require conf/machine/imx8mm-lpddr4-evk.conf

to

MACHINEOVERRIDES =. "imx8mm-ddr4-evk:"
require conf/machine/imx8mm-ddr4-evk.conf
@thochstein
Copy link
Contributor

Hi @vlaarco. I suspect that you should just use imx8mm-lpddr4-evk and imx8mm-ddr4-evk directly. Changing imx8mmevk.conf as you describe is not something we do or recommend.

https://github.com/nxp-imx/meta-imx/blob/scarthgap-6.6.36-2.1.0/meta-imx-bsp/conf/machine/imx8mmevk.conf

@@ -6,7 +6,7 @@

require include/imx8mm-evk.inc

KERNEL_DEVICETREE_BASENAME = "${MACHINE}"
KERNEL_DEVICETREE_BASENAME = "imx8mm-ddr4-evk"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the commit lock to use the machine name as prefix and use the message that you sent and the pull request as the commit message for more detail

@otavio
Copy link
Member

otavio commented Nov 13, 2024

Hi @vlaarco. I suspect that you should just use imx8mm-lpddr4-evk and imx8mm-ddr4-evk directly. Changing imx8mmevk.conf as you describe is not something we do or recommend.

https://github.com/nxp-imx/meta-imx/blob/scarthgap-6.6.36-2.1.0/meta-imx-bsp/conf/machine/imx8mmevk.conf

Is my understanding correct that this issue is not to be fixed here? @thochstein

@vlaarco
Copy link
Author

vlaarco commented Nov 13, 2024

Hi @vlaarco. I suspect that you should just use imx8mm-lpddr4-evk and imx8mm-ddr4-evk directly. Changing imx8mmevk.conf as you describe is not something we do or recommend.
https://github.com/nxp-imx/meta-imx/blob/scarthgap-6.6.36-2.1.0/meta-imx-bsp/conf/machine/imx8mmevk.conf

Is my understanding correct that this issue is not to be fixed here? @thochstein

Ah yes, I see what my problem is. This fix is no longer required. Please close this PR. Keep up the good work!

@vlaarco vlaarco closed this Nov 13, 2024
@vlaarco vlaarco deleted the vlaarco-imx8mm-ddr4-evk branch November 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants