fix issue#2511

[Petrificus-totalus]

This fixes issue #2511
My wallet address is 0x4c35271cA4fF57adEc0E28cAc6AF5D51E37bF378

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Oct 21, 2023 0:19am

[ghost]

👇 Click on the image for a new way to code review

Legend

[DreadKnight]

@Petrificus-totalus I've still managed to get the logo to show up awkwardly by switching tabs via hotkeys. Needs more work.

[Petrificus-totalus]

I modified the dev environment which runs at 'localhost:8080', so do I need to do the npm run build:dev and then do 'git push', thanks for your patience. :)

[Petrificus-totalus]

I modified the dev environment which runs at 'localhost:8080', so do I need to do the npm run build:dev and then do 'git push', thanks for your patience. :)

I did the build-and-push, and it seems to be working on the website you are testing. @DreadKnight

[DreadKnight]

Idea was that your patch doesn't quite cut it, even if the code looks alright. I'm using latest slable version of Brave. In the screenshot that's just an automatic build of the game with your patch for easy reviewing, you can access it as well from around here.

…

On Fri, Oct 20, 2023, 1:44 AM Petrificus-totalus ***@***.***> wrote: I modified the dev environment which runs at 'localhost:8080', so do I need to do the npm run build:dev and then do 'git push', thanks for your patience. :) I did the build-and-push, and it seems to be working on the website you are testing. @DreadKnight <https://github.com/DreadKnight> — Reply to this email directly, view it on GitHub <#2514 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEPNX6KWQOHK2SE4JRFBV3YAGUNNAVCNFSM6AAAAAA6GKKTA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRHAYDIMZRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Petrificus-totalus]

I believe it might be an issue with browser and operating system compatibility. May I ask which hotkey you are using? Apologies for asking so many questions.

[DreadKnight]

Hotkeys used are Ctrl+Shift+Tab and some Ctrl+Tab as well, the standard stuff. Will test the issue with Firefox as well when I get the chance.

…

On Fri, Oct 20, 2023, 2:33 AM Petrificus-totalus ***@***.***> wrote: I believe it might be an issue with browser and operating system compatibility. May I ask which hotkey you are using? Apologies for asking so many questions. — Reply to this email directly, view it on GitHub <#2514 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEPNX4SVAM56VUHOEMBSD3YAG2DZAVCNFSM6AAAAAA6GKKTA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRHA2DAMZUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Petrificus-totalus]

oh, got it. I have been testing my laptop using shift+tab. Thanks for your reply.

[Petrificus-totalus]

@DreadKnight Hi, I think I solved it. I've chosen to listen for when the game webpage becomes hidden, which happens when switching between web pages. If it disappears, the logo will be hidden.

[DreadKnight]

@Petrificus-totalus Heya! Seems to be working properly now. You forgot to mark this ready for review :P Bounty sent 🪙

[Petrificus-totalus]

Thanks a lot. Is there anything else to do for this issue, please let me know.

[DreadKnight]

@Petrificus-totalus Heya! Found another scenario related to this kind of stuff, I've opened new issue for it -> #2521

[Petrificus-totalus]

@DreadKnight Sorry, sir. I have to prepare my final exams these days.

[DreadKnight]

@Petrificus-totalus No worries, good luck with those! 🐻