-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added bounce animation on skip button #2593
[Feature] Added bounce animation on skip button #2593
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@prateeksingh19 I see no bounce at all... |
that's strange, i can see it in mine, i just checked it rn. |
@prateeksingh19 Retested. Bounce only happens once when I click on unit itself and turn gets skipped. I take it you didn't read properly the issue once again 🐻 |
@prateeksingh19 Pretty good now. |
Ok, Will do. Thanks for the review. |
this is a test to avoid a small visual glitch; might revert
@prateeksingh19 Alrighty. Patched it myself as well a bit, was hoping to make the button's animation sort of finish by itself on hover and then stop instead of snapping back into place, but didn't work as expected, oh well... Will merge and send bounty in a bit. |
@prateeksingh19 Bounty sent with bonus -> https://www.mintme.com/explorer/tx/0x86bca1cab11b8bd55851329608fc3260535eb24d85d4543fa26c05aabd6c610c 🪙 |
Thanks. Enjoyed working with you. |
Cool! 👍🏻 Every little patch helps out in the grand image. Hopefully will see more PRs from you as well. Feel free to poke at related issue -> #1976 |
This fixes issue #2535 added bounce animation on skip button only when unit is out of actions and not when skip button is clicked manually.
Added animations in styles file for skip bounce button.
Attached bounce class to the skip button when the unit is out of actions. Removed the bounce class from the skip button after 3s using setTImeout.
My wallet address is 0x252b0dB01b57eC7A4A02c05cc06A0529d43C7142