Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Gumble's passive ability #2654

Closed

Conversation

vishwamartur
Copy link

Related to #2635

Revamp Gumble's passive ability 'Gooey Body' to create a trap when Gumble is killed.

  • Modify src/abilities/Gumble.ts to implement the new 'Gooey Body' ability.
    • When Gumble is killed, create a trap at Gumble's location that pins any unit that walks over it.
    • The trap prevents movement for the current round but allows the use of abilities.
    • Movement-related abilities can free the unit if landing outside the goo.
    • The trap remains until overlapped by another similar trap.
    • The upgraded ability does not affect allied units.
  • Add the sprite file assets/autoload/phaser/units/sprites/trap_goey-body.png to the repository.
  • Ensure the new ability is triggered by the 'onDeath' event.

Related to FreezingMoon#2635

Revamp Gumble's passive ability 'Gooey Body' to create a trap when Gumble is killed.

* Modify `src/abilities/Gumble.ts` to implement the new 'Gooey Body' ability.
  * When Gumble is killed, create a trap at Gumble's location that pins any unit that walks over it.
  * The trap prevents movement for the current round but allows the use of abilities.
  * Movement-related abilities can free the unit if landing outside the goo.
  * The trap remains until overlapped by another similar trap.
  * The upgraded ability does not affect allied units.
* Add the sprite file `assets/autoload/phaser/units/sprites/trap_goey-body.png` to the repository.
* Ensure the new ability is triggered by the 'onDeath' event.
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ❌ Failed (Inspect) Nov 27, 2024 11:19am

@DreadKnight
Copy link
Member

@vishwamartur Heya! Thanks for the PR. Vercel threw some errors when trying to build this, so I'm not yet able to test:

[13:18:32.354] Running build in Washington, D.C., USA (East) – iad1
[13:18:32.460] Cloning github.com/FreezingMoon/AncientBeast (Branch: revamp-gumble-ability, Commit: 00627d8)
[13:18:35.358] Cloning completed: 2.898s
[13:18:35.683] Restored build cache from previous deployment (7T5WmX7igvvhpfwwTMRvQzmAAxs7)
[13:18:35.778] Running "vercel build"
[13:18:36.181] Vercel CLI 39.1.1
[13:18:36.890] Warning: Due to "engines": { "node": "20.x" } in your package.json file, the Node.js Version defined in your Project Settings ("18.x") will not apply, Node.js Version "20.x" will be used instead. Learn More: http://vercel.link/node-version
[13:18:36.896] Running "install" command: npm install...
[13:18:39.142]
[13:18:39.143] changed 2 packages, and audited 1071 packages in 2s
[13:18:39.143]
[13:18:39.143] 131 packages are looking for funding
[13:18:39.143] run npm fund for details
[13:18:39.145]
[13:18:39.145] 1 high severity vulnerability
[13:18:39.145]
[13:18:39.145] To address all issues, run:
[13:18:39.146] npm audit fix
[13:18:39.146]
[13:18:39.146] Run npm audit for details.
[13:18:39.390]
[13:18:39.391] > [email protected] build:dev
[13:18:39.391] > webpack --mode=development
[13:18:39.391]
[13:18:39.991] Failed to load ./.env.
[13:19:04.213] assets by path assets/units/ 3.73 MiB 370 assets
[13:19:04.214] assets by path assets/autoload/phaser/ 421 KiB 73 assets
[13:19:04.214] assets by path assets/stats/ 172 KiB 38 assets
[13:19:04.215] assets by path assets/icons/ 57.1 KiB 34 assets
[13:19:04.215] assets by path assets/interface/ 685 KiB 24 assets
[13:19:04.215] assets by path .js 34.9 MiB 23 assets
[13:19:04.215] assets by path assets/music/ 62.4 MiB 17 assets
[13:19:04.215] assets by path assets/drops/stock/
.png 3.68 KiB 12 assets
[13:19:04.215] assets by path assets/sounds/.ogg 252 KiB 9 assets
[13:19:04.216] assets by path assets/cards/ 110 KiB 9 assets
[13:19:04.216] assets by path assets/locations/ 791 KiB 4 assets
[13:19:04.216] assets by path assets/fonts/ 75.3 KiB 4 assets
[13:19:04.216] + 4 assets
[13:19:04.216] runtime modules 8.48 KiB 13 modules
[13:19:04.216] javascript modules 8.95 MiB
[13:19:04.217] modules by path ./node_modules/ 7.87 MiB 635 modules
[13:19:04.217] modules by path ./src/ 1.01 MiB 71 modules
[13:19:04.217] ./assets/index.js 62.6 KiB [built] [code generated]
[13:19:04.217] asset modules 24.4 KiB (javascript) 68.7 MiB (asset) 595 modules
[13:19:04.217] json modules 37.7 KiB
[13:19:04.217] ./package.json 2.44 KiB [built] [code generated]
[13:19:04.217] ./node_modules/node-emoji/lib/emoji.json 35.2 KiB [built] [code generated]
[13:19:04.218]
[13:19:04.218] ERROR in /vercel/path0/src/abilities/Gumble.ts
[13:19:04.218] ./src/abilities/Gumble.ts 21:3-10
[13:19:04.218] [tsl] ERROR in /vercel/path0/src/abilities/Gumble.ts(21,4)
[13:19:04.218] TS2322: Type '"onDeath"' is not assignable to type 'Trigger'.
[13:19:04.218] @ ./src/abilities/ lazy ^./.
$ namespace object ./Gumble.ts ./Gumble
[13:19:04.219] @ ./src/script.ts 35:4-63
[13:19:04.219]
[13:19:04.219] ERROR in /vercel/path0/src/abilities/Gumble.ts
[13:19:04.219] ./src/abilities/Gumble.ts 37:17-27
[13:19:04.219] [tsl] ERROR in /vercel/path0/src/abilities/Gumble.ts(37,18)
[13:19:04.219] TS2339: Property 'isUpgraded' does not exist on type 'Partial'.
[13:19:04.219] @ ./src/abilities/ lazy ^./.$ namespace object ./Gumble.ts ./Gumble
[13:19:04.220] @ ./src/script.ts 35:4-63
[13:19:04.220]
[13:19:04.220] ERROR in /vercel/path0/src/abilities/Gumble.ts
[13:19:04.220] ./src/abilities/Gumble.ts 37:56-64
[13:19:04.220] [tsl] ERROR in /vercel/path0/src/abilities/Gumble.ts(37,57)
[13:19:04.220] TS2339: Property 'creature' does not exist on type 'Partial'.
[13:19:04.221] @ ./src/abilities/ lazy ^./.
$ namespace object ./Gumble.ts ./Gumble
[13:19:04.221] @ ./src/script.ts 35:4-63
[13:19:04.221]
[13:19:04.221] ERROR in /vercel/path0/src/abilities/Gumble.ts
[13:19:04.221] ./src/abilities/Gumble.ts 43:17-30
[13:19:04.221] [tsl] ERROR in /vercel/path0/src/abilities/Gumble.ts(43,18)
[13:19:04.221] TS2339: Property 'remainingMove' does not exist on type 'EffectFnArg'.
[13:19:04.222] Property 'remainingMove' does not exist on type 'number'.
[13:19:04.222] @ ./src/abilities/ lazy ^./.$ namespace object ./Gumble.ts ./Gumble
[13:19:04.222] @ ./src/script.ts 35:4-63
[13:19:04.222]
[13:19:04.222] ERROR in /vercel/path0/src/abilities/Gumble.ts
[13:19:04.222] ./src/abilities/Gumble.ts 52:6-22
[13:19:04.222] [tsl] ERROR in /vercel/path0/src/abilities/Gumble.ts(52,7)
[13:19:04.222] TS2554: Expected 6 arguments, but got 7.
[13:19:04.223] @ ./src/abilities/ lazy ^./.
$ namespace object ./Gumble.ts ./Gumble
[13:19:04.223] @ ./src/script.ts 35:4-63
[13:19:04.223]
[13:19:04.223] 5 errors have detailed information that is not shown.
[13:19:04.223] Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
[13:19:04.223]
[13:19:04.223] webpack 5.94.0 compiled with 5 errors in 23784 ms
[13:19:04.310] Error: Command "npm run build:dev" exited with 1
[13:19:04.647]

@vishwamartur
Copy link
Author

Sure let me check on it

@DreadKnight DreadKnight marked this pull request as draft December 8, 2024 03:46
@DreadKnight
Copy link
Member

🐻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants