This fixes issue #issue 2651 #2656
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file to map avatar types to their image paths.
Instead of manually specifying a background-image for each type, the avatar image is assigned using JavaScript and the avatars.json file.
Handles dynamic assignment of avatar images using the avatars.json configuration.
Automatically generates avatars.json at build time by scanning the avatars folder.
Confirms avatars.json is generated correctly and included in the deployed build directory.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Heya! Thanks for the PR. Seems it fails to build. Also, please always ping issues using hashtag and then number: #2651 |
DreadKnight
requested changes
Dec 5, 2024
|
@MathioLucas I've opened a review. "package.json" is the faulty file, very obvious problem there 🐻 |
|
@MathioLucas PR titles should be more descriptive, something like "auto-generated unit avatar grid at build time" in this case, as even if properly tagging the issue there, it won't be clickable (like it can be in description). Plus it's way more useful when stuff is reviewed and very importantly, when generating the list of changes for a new version release. |
|
@MathioLucas Hey! Still waiting for a fix on this one 🐻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #issue 2651
a quick summary for file changes and additions
avatars.less
Replaced hardcoded avatar types with a single CSS class using variables.
avatars.json
Updated .typeXX classes to .vignette with a data-type attribute.
avatarLoader.js
Create this new file to dynamically assign avatar images.
Import avatarLoader.js.
To Automate the creation of avatars.json during build time.