-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 7 #203
Support Symfony 7 #203
Conversation
I think |
Symfony 7 was released today |
@Yozhef: this PR seems ready to be merged? |
The first step is to approve the ci run and check results. |
Sure, but I guess only mainteners can run CI |
Actually, 6.0-6.2 aren't supported either. I think it should be 5.4 || ^6.3 || ^7.0 |
@Jeroeny you can leave version 4.4 - in order not to issue a major release that will require major changes |
I think @Jeroeny means "drop" 4.4 (not leave as in "leave it in", but leave as it drop it). |
@Yozhef so should it become |
@Jeroeny yes, if remove 4.4 we need create a new major release. But at the moment I don't see a great need for it |
Why do you need a new major version for drop support of an unsupported Symfony version? |
I think the issue is that if supporting an unsupported version of Symfony is keeping it from supporting the current version of Symfony, the preference should be to support the release version and not the old version. |
I also don't think it'd need a major release, because composer would prevent the minor update anyway if you're still on Symfony 4.4. |
@pamil Could you help us with this one too please? |
This pr - add only composer but need add ci see https://github.com/FriendsOfBehat/SymfonyExtension/pull/205/files |
Add support for Symfony 7. It seems no changes were necessary. The Client alias could be removed because it only existed in Symfony 4.x