Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #203

Closed
wants to merge 1 commit into from
Closed

Support Symfony 7 #203

wants to merge 1 commit into from

Conversation

Jeroeny
Copy link

@Jeroeny Jeroeny commented Nov 1, 2023

Add support for Symfony 7. It seems no changes were necessary. The Client alias could be removed because it only existed in Symfony 4.x

@Chris53897
Copy link

I think 5.3 || ^6.0 || ^7.0 should be changed to 5.4 || ^6.0 || ^7.0. As only 5.4 has LTS

@damien-louis
Copy link

Symfony 7 was released today
https://symfony.com/blog/symfony-7-0-0-released

@damien-louis
Copy link

@Yozhef: this PR seems ready to be merged?

@Chris53897
Copy link

The first step is to approve the ci run and check results.

@damien-louis
Copy link

Sure, but I guess only mainteners can run CI

@tacman
Copy link

tacman commented Nov 30, 2023

5.4 || ^6.0 || ^7.0.

Actually, 6.0-6.2 aren't supported either. I think it should be

5.4 || ^6.3 || ^7.0

@Yozhef
Copy link
Contributor

Yozhef commented Dec 1, 2023

@Jeroeny you can leave version 4.4 - in order not to issue a major release that will require major changes

@tacman
Copy link

tacman commented Dec 1, 2023

I think @Jeroeny means "drop" 4.4 (not leave as in "leave it in", but leave as it drop it).

@Jeroeny
Copy link
Author

Jeroeny commented Dec 1, 2023

@Yozhef so should it become ^4.4 || ^5.4 || ^6.4 || ^7.0"?

@Yozhef
Copy link
Contributor

Yozhef commented Dec 1, 2023

@Jeroeny yes, if remove 4.4 we need create a new major release. But at the moment I don't see a great need for it

@Chris53897
Copy link

Why do you need a new major version for drop support of an unsupported Symfony version?

@tacman
Copy link

tacman commented Dec 1, 2023

But at the moment I don't see a great need for it

I think the issue is that if supporting an unsupported version of Symfony is keeping it from supporting the current version of Symfony, the preference should be to support the release version and not the old version.

@Jeroeny
Copy link
Author

Jeroeny commented Dec 1, 2023

I also don't think it'd need a major release, because composer would prevent the minor update anyway if you're still on Symfony 4.4.
But I will readd ^4.4, since this is not up to me :).

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@loic425
Copy link

loic425 commented Dec 4, 2023

@pamil Could you help us with this one too please?

@loic425 loic425 mentioned this pull request Dec 4, 2023
74 tasks
@Yozhef
Copy link
Contributor

Yozhef commented Jan 11, 2024

This pr - add only composer but need add ci see https://github.com/FriendsOfBehat/SymfonyExtension/pull/205/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants