Merge pull request #481 from FriendsOfPHP/deprecation

Add some deprecation notice to encourage people to use HttpBrowser instead from the Symfony BrowserKit component

Goutte/Client.php

@@ -11,11 +11,22 @@
 
 namespace Goutte;
 
+use Symfony\Component\BrowserKit\CookieJar;
+use Symfony\Component\BrowserKit\History;
 use Symfony\Component\BrowserKit\HttpBrowser;
+use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 /**
  * @author Fabien Potencier <[email protected]>
+ *
+ * @deprecated Use Symfony\Component\BrowserKit\HttpBrowser directly instead
  */
 class Client extends HttpBrowser
 {
+    public function __construct(HttpClientInterface $client = null, History $history = null, CookieJar $cookieJar = null)
+    {
+        trigger_deprecation('fabpot/goutte', '4.0', 'The "%s" class is deprecated, use "%s" instead.', __CLASS__, HttpBrowser::class);
+
+        parent::__construct($client, $history, $cookieJar);
+    }
 }

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2010-2016 Fabien Potencier
+Copyright (c) 2010-present Fabien Potencier
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.rst

@@ -6,6 +6,13 @@ Goutte is a screen scraping and web crawling library for PHP.
 Goutte provides a nice API to crawl websites and extract data from the HTML/XML
 responses.
 
+**WARNING**: This library is deprecated. As of v4, Goutte became a simple proxy
+to the `HttpBrowser class
+<https://symfony.com/doc/current/components/browser_kit.html#making-external-http-requests>`_
+from the `Symfony BrowserKit <https://symfony.com/browser-kit>`_ component. To
+migrate, replace ``Goutte\\Client`` by
+``Symfony\\Component\\BrowserKit\\HttpBrowser`` in your code.
+
 Requirements
 ------------
 

composer.json

@@ -13,14 +13,15 @@
     ],
     "require": {
         "php": ">=7.1.3",
+        "symfony/deprecation-contracts": "^2.1|^3",
         "symfony/browser-kit": "^4.4|^5.0|^6.0",
         "symfony/css-selector": "^4.4|^5.0|^6.0",
         "symfony/dom-crawler": "^4.4|^5.0|^6.0",
         "symfony/http-client": "^4.4|^5.0|^6.0",
         "symfony/mime": "^4.4|^5.0|^6.0"
     },
     "require-dev": {
-        "symfony/phpunit-bridge": "^5.0|^6.0"
+        "symfony/phpunit-bridge": "^6.0"
     },
     "autoload": {
         "psr-4": { "Goutte\\": "Goutte" },