Merge pull request #610 from XWB/threads404

Throw 404 if fos_comment_get_threads is called without parameters
FriendsOfSymfony · Aug 24, 2017 · d6c6569 · d6c6569
2 parents ce7a477 + 7c9ded7
commit d6c6569
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/Controller/ThreadController.php b/Controller/ThreadController.php
@@ -86,6 +86,10 @@ public function getThreadsActions(Request $request)
     {
         $ids = $request->query->get('ids');
 
+        if (null === $ids) {
+            throw new NotFoundHttpException('Cannot query threads without id\'s.');
+        }
+
         $threads = $this->container->get('fos_comment.manager.thread')->findThreadsBy(array('id' => $ids));
 
         $view = View::create()

diff --git a/Tests/Functional/ApiTest.php b/Tests/Functional/ApiTest.php
@@ -45,6 +45,19 @@ public function testGetThread404()
         $this->assertEquals(404, $this->client->getResponse()->getStatusCode());
     }
 
+    /**
+     * Tests retrieval of a threads without id's.
+     *
+     * fos_comment_get_threads: GET: /comment_api/threads
+     */
+    public function testGetThreads404()
+    {
+        $this->client->insulate(true);
+
+        $this->client->request('GET', '/comment_api/threads');
+        $this->assertEquals(404, $this->client->getResponse()->getStatusCode());
+    }
+
     /**
      * Tests creation of a new form.retrieval of a thread that doesnt exist.
      *