Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 to 3 #584

Merged
merged 4 commits into from
Aug 2, 2024
Merged

2 to 3 #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8335e8f
fix symfony 4 compatibility
dbu Aug 2, 2024
4df8da8
prepare release
dbu Aug 2, 2024
6823287
Merge remote-tracking branch 'origin/2.x' into 2-to-3
dbu Aug 2, 2024
4b53b92
re-type the parameter as 3.x does no longer support Symfony 4
dbu Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,19 @@ See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpC
2.x
===

2.16.1
2.16.2
------

### Fixed

* The new `EventDispatchingHttpCache::forward` method added in 2.16.0 was not
compatible with Symfony 4.4. Adjusted the signature to make it compatible.

2.16.1
------

(Mistaken tag, same as 2.16.0)

2.16.0
------

Expand Down
2 changes: 1 addition & 1 deletion src/SymfonyCache/EventDispatchingHttpCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ protected function invalidate(Request $request, bool $catch = false): Response
return parent::invalidate($request, $catch);
}

protected function forward(Request $request, $catch = false, ?Response $entry = null): Response
protected function forward(Request $request, bool $catch = false, ?Response $entry = null): Response
{
// do not abort early, if $entry is set this is a validation request
$this->dispatch(Events::PRE_FORWARD, $request, $entry);
Expand Down