Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
preparing a stable release
Browse files Browse the repository at this point in the history
  • Loading branch information
@lsmith77
lsmith77 committed Oct 10, 2013
1 parent b773e2e commit ec9b1d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"target-dir": "FOS/Rest",
"extra": {
"branch-alias": {
"dev-master": "0.9.x-dev"
"dev-master": "1.0-dev"
}
}
}

4 comments on commit ec9b1d9

@stof
Copy link
Member

@stof stof commented on ec9b1d9 Oct 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't you planning to deprecate FOSRest entirely now that the content negotation uses a different library ? FOSRest does not ship any really useful feature anymore (the body decoders in themselves are not really worth it, especially as the decoding logic seems to be copied from the Symfony Serializer component but without the fixes to parse XML in a safe way)

@lsmith77
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point .. totally forgot about that. the Codes class is moving to core with 2.4 but needs to remain for now. the BC breaks moving this code would mean can be fixed with a bit of search and replace.

@oleg-andreyev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @stof

@lsmith77
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how it would look like if we reintegrate this code FriendsOfSymfony/FOSRestBundle#583

Please sign in to comment.