Add TYPO3 13 compatibility #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FrontendController to link modifier since method became protected in TYPO3 13
bmack
reviewed
Nov 5, 2024
| */ | ||
| protected function getPageTsConfig(ServerRequestInterface $request): array | ||
| { | ||
| $pageInformation = $request->getAttribute('frontend.page.information'); |
There was a problem hiding this comment.
This change only works in v13, but the changes you make in composer.json says that the code should also stay compatible with older versions.
How about we make it work for v12 and v13 at the same time and drop the older versions?
There was a problem hiding this comment.
Here you go ...
bmack
approved these changes
Nov 15, 2024
|
thanks for your work on this @mediaessenz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57