Skip to content

Commit

Permalink
chore: update Sass notation for breaking changes in next version (#2178)
Browse files Browse the repository at this point in the history
  • Loading branch information
SamuelAlev authored Jan 28, 2025
1 parent 17ea184 commit 425d2f1
Show file tree
Hide file tree
Showing 28 changed files with 499 additions and 402 deletions.
5 changes: 5 additions & 0 deletions .changeset/modern-camels-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@frontify/fondue-components": patch
---

chore: update Sass notation for breaking changes in next version
11 changes: 6 additions & 5 deletions packages/components/src/components/Box/styles/box.module.scss
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
/* (c) Copyright Frontify Ltd., all rights reserved. */

@import '../../../helpers/layout.module.scss';
@use "sass:list";
@use '../../../helpers/layout.module.scss';

$properties: (display);
$allProperties: join($properties, $layoutProperties);
$allProperties: list.join($properties, layout.$layoutProperties);

.root {
@include responsive-properties($allProperties);
@include layout.responsive-properties($allProperties);

// Default values
@each $property in $allProperties {
@include responsive-default-value($property, initial);
@include layout.responsive-default-value($property, initial);
}

@include responsive-default-value(display, block);
@include layout.responsive-default-value(display, block);
}
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
/* (c) Copyright Frontify Ltd., all rights reserved. */
@import '../../../utilities/sizeToken.module.scss';
@import '../../../utilities/focusStyle.module.scss';
@import '../../../utilities/transitions.module.scss';
@use '../../../utilities/sizeToken.module.scss';
@use '../../../utilities/focusStyle.module.scss';
@use '../../../utilities/transitions.module.scss';

.root {
@include transition-colors;

width: 100%;
position: relative;
justify-content: start;
align-items: center;
gap: sizeToken(2);
gap: sizeToken.get(2);
overflow: hidden;

font-family: var(--body-family-stack);
Expand All @@ -25,6 +23,10 @@
border-radius: var(--radius);
border: var(--line-width) solid var(--line-color-strong);

& {
@include transitions.transition-colors;
}

&:hover {
border-color: var(--line-color-x-strong);
color: var(--text-color-weak);
Expand All @@ -37,7 +39,7 @@
}

&:has(button[data-color-input-select]:focus-visible) {
@include focus-outline-styles
@include focusStyle.focus-outline-styles;
}

&:has(input:disabled),
Expand All @@ -53,40 +55,40 @@
display: flex;
justify-content: start;
align-items: center;
gap: sizeToken(2);
gap: sizeToken.get(2);
flex-grow: 1;
padding-left: sizeToken(3);
padding-right: sizeToken(3);
height: sizeToken(9);
padding-left: sizeToken.get(3);
padding-right: sizeToken.get(3);
height: sizeToken.get(9);
outline: none;
width: 100%;
}

.colorIndicator {
width: sizeToken(4);
height: sizeToken(4);
border-radius: sizeToken(1);
width: sizeToken.get(4);
height: sizeToken.get(4);
border-radius: sizeToken.get(1);
}

.actions {
position: absolute;
top: 0;
bottom: 0;
right: sizeToken(3);
right: sizeToken.get(3);
display: flex;
align-items: center;
pointer-events: none;
}
.clear {
outline: none;
padding: sizeToken(1);
margin: sizeToken(1);
@include focus-outline;
padding: sizeToken.get(1);
margin: sizeToken.get(1);
@include focusStyle.focus-outline;
pointer-events: all;
}

.caret {
@include transition-all;
@include transitions.transition-all;
}

[data-state='open'] {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
/* (c) Copyright Frontify Ltd., all rights reserved. */

@import '../../../utilities/sizeToken.module.scss';
@import '../../../utilities/focusStyle.module.scss';
@use '../../../utilities/sizeToken.module.scss';
@use '../../../utilities/focusStyle.module.scss';

.root {
display: flex;
flex-direction: column;
gap: sizeToken(4);
gap: sizeToken.get(4);
max-width: 700px;
container-type: inline-size;
}

.inputs {
display: grid;
grid-template-columns: 1fr;
gap: sizeToken(2);
gap: sizeToken.get(2);

@container (min-width: 19.5rem) {
grid-template-columns: 100px 1fr 100px;
Expand All @@ -29,7 +29,7 @@
.colorChannelInputGroup {
display: flex;
flex-direction: column;
gap: sizeToken(2);
gap: sizeToken.get(2);

@container (min-width: 19.5rem) {
flex-direction: row;
Expand All @@ -50,7 +50,6 @@

//remove arrows from number inputs
.valueInput {

input::-webkit-outer-spin-button,
input::-webkit-inner-spin-button {
-webkit-appearance: none;
Expand Down
Loading

0 comments on commit 425d2f1

Please sign in to comment.