cleanup

Frontify · Jan 29, 2025 · 7b88609 · 7b88609
1 parent ca75f2c
commit 7b88609
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/packages/charts/src/components/BarChart/BarChart.stories.tsx b/packages/charts/src/components/BarChart/BarChart.stories.tsx
@@ -110,7 +110,7 @@ const planetsRadiusDataWithSingleClickable = (() => {
         return {
             label: item.name,
             value: parseFloat(item.radius),
-            onBarClick: index === 0 ? () => window.open('https://frontify.com') : undefined,
+            onBarClick: index === 0 ? () => window.open('https://frontify.com', '_blank', 'noopener') : undefined,
         };
     });
 
@@ -190,22 +190,9 @@ const addOnClickToFirstPoint = (series: BarChartSeries[]): BarChartSeries[] => {
         ...singleSeries,
         dataPoints: singleSeries.dataPoints.map((dataPoint, index) => ({
             ...dataPoint,
-            onBarClick: index === 0 ? () => window.open('https://frontify.com') : undefined,
+            onBarClick: index === 0 ? () => window.open('https://frontify.com', '_blank', 'noopener') : undefined,
         })),
     }));
-    // return series.reduce(
-    //     (prev, curr) => [
-    //         ...prev,
-    //         {
-    //             ...curr,
-    //             dataPoints: curr.dataPoints.map((dataPoint, index) => ({
-    //                 ...dataPoint,
-    //                 onBarClick: index === 0 ? () => window.open('https://frontify.com') : null,
-    //             })),
-    //         },
-    //     ],
-    //     [],
-    // );
 };
 
 const planetImagesMap: Record<string, string> = {

diff --git a/packages/charts/src/components/BarChart/components/Bars.tsx b/packages/charts/src/components/BarChart/components/Bars.tsx
@@ -28,7 +28,7 @@ export const Bars = ({ series, horizontal, displayStyle }: BarGroupProps) => {
         }
     };
     const onPointerOut = () => setFocusedItemLabel(null);
-    const onPointerDown = (e: EventHandlerParams<BarChartDataPoint>) => e.datum.onBarClick && e.datum.onBarClick(e);
+    const onPointerDown = (e: EventHandlerParams<BarChartDataPoint>) => e.datum.onBarClick?.(e);
 
     const seriesElements = series.map((item, seriesIndex) => (
         <BarSeries