feat: add max-width and adjust styling of tooltip image and description text #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 51fac3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
jose-costa-frontify
approved these changes
Nov 26, 2024
SamuelAlev
approved these changes
Nov 26, 2024
|
Lead time: 3 hours, 51 minutes, 9 seconds (3.85 total hours) from first commit to close.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips with long, single word (with dashes or underscores) titles look strange when the template preview image is shown. (See the image below for an example from Superheroes).
This PR fixes the issue by adding a max-width, and setting the image to full width. It also includes an update to truncate the description lines (in this case Brand, Project, etc.) as requested by our team's designer.
Before:
After:
