Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow different bar chart click behavior per data point #2129

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joewoodson
Copy link
Contributor

DO NOT MERGE - requires changes in webapp to avoid breaking current click behavior

Allow for more granular control over bar chart click behavior (per data point), and only set cursor to pointer when bar is clickable.

@joewoodson joewoodson self-assigned this Dec 5, 2024
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 7b88609

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR Preview Action v1.5.0
🚀 Deployed preview to https://Frontify.github.io/fondue/pr-preview/pr-2129/
on branch gh-pages at 2025-01-29 09:37 UTC

@joewoodson
Copy link
Contributor Author

Closing for now, as other tasks have higher priority.

@joewoodson joewoodson closed this Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Lead time: 3 days, 19 hours, 43 minutes, 41 seconds (91.73 total hours) from first commit to close.
Review time: 0 seconds (0 total hours) from ready for review to close.

  • First commit: 5.12.2024, 13:09:14.
  • Ready for review: N/A.
  • Closed: 9.12.2024, 08:52:55.

@joewoodson joewoodson reopened this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant