Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass ref everywhere we use forwardRef to avoid warnings #2174

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

SamuelAlev
Copy link
Member

Prevents these warnings
Screenshot 2025-01-23 at 15 59 43

@SamuelAlev SamuelAlev self-assigned this Jan 23, 2025
@SamuelAlev SamuelAlev requested a review from a team as a code owner January 23, 2025 15:00
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 3c34eea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 23, 2025

PR Preview Action v1.5.0
Preview removed because the pull request was closed.
2025-01-27 10:17 UTC

@SamuelAlev SamuelAlev merged commit a1eb58f into main Jan 27, 2025
15 checks passed
@SamuelAlev SamuelAlev deleted the fix/ref-layout-comp-warning branch January 27, 2025 10:17
Copy link
Contributor

Lead time: 3 days, 19 hours, 17 minutes, 33 seconds (91.29 total hours) from first commit to close.
Review time: 3 days, 19 hours, 17 minutes, 1 seconds (91.28 total hours) from ready for review to close.

  • First commit: 23.1.2025, 15:59:31.
  • Ready for review: 23.1.2025, 16:00:03.
  • Closed: 27.1.2025, 11:17:04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants