Skip to content

Commit

Permalink
rpmbuild: save review.json from fedora-review
Browse files Browse the repository at this point in the history
See https://pagure.io/FedoraReview/pull-request/463
See https://pagure.io/FedoraReview/issue/310

I am planning to use this file from the fedora-review-service and
provide users better feedback based on that.

Also, we don't need to depend on a specific fedora-review version. If
the file is not present, we skip it without failing.
  • Loading branch information
FrostyX authored and praiskup committed Aug 11, 2023
1 parent 727b40b commit 447bb4a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rpmbuild/copr_rpmbuild/automation/fedora_review.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ def _filter_results_directory(self):
self.log.error("Can't find fedora-review results: %s", srcdir)
return

results = ["review.txt", "licensecheck.txt", "rpmlint.txt", "files.dir"]
results = ["review.txt", "review.json", "licensecheck.txt",
"rpmlint.txt", "files.dir"]
for result in results:
try:
os.rename(os.path.join(srcdir, result),
Expand Down

0 comments on commit 447bb4a

Please sign in to comment.