Update Specs to Include Gas Price changes #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
changed the title
xgreenx
reviewed
Feb 19, 2024
MitchTurner
commented
Feb 22, 2024
| @@ -212,14 +212,14 @@ def max_gas(tx) -> int: | |||
| if tx.type == TransactionType.Script: | |||
| gas = gas + tx.gasLimit | |||
| return gas | |||
|
|
|||
|
|
|||
| def reserved_feeBalance(tx, assetId) -> int: | |||
There was a problem hiding this comment.
I couldn't find any function with this name in our code, and it sounds like max_fee, so I changed it. Might be wrong.
There was a problem hiding this comment.
Yeah, in the code analog is max_fee function=) Could you also update other places here(reserved_fee_balance), please?
Dentosal
previously approved these changes
Mar 11, 2024
xgreenx
reviewed
Mar 11, 2024
| @@ -212,14 +212,14 @@ def max_gas(tx) -> int: | |||
| if tx.type == TransactionType.Script: | |||
| gas = gas + tx.gasLimit | |||
| return gas | |||
|
|
|||
|
|
|||
| def reserved_feeBalance(tx, assetId) -> int: | |||
There was a problem hiding this comment.
Yeah, in the code analog is max_fee function=) Could you also update other places here(reserved_fee_balance), please?
src/tx-format/policy.md
Outdated
|
|
||
| Transaction is invalid if: | ||
|
|
||
| - `max_fee` is not set |
There was a problem hiding this comment.
Maybe it is better to move this check to where the gas price was.
There was a problem hiding this comment.
I'm not sure I understand. Move this section to where the ## GasPrice section was? Which "gas price" are you referring to?
xgreenx
requested changes
Mar 11, 2024
xgreenx
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#546
This includes the changes for:
gas_pricefrom txgas_priceonMinttxGasPricepolicyTippolicyMaxFeemandatorySince there is no concept of the client API in these specs, and also the implementation of tx checks, I didn't include:
gas_priceestimate or latestgas_priceAPI endpointsChecked<Tx>That's fine if we don't want the scope of the VM to include those sort of things, but it's not clear to me what these specs are constrained by.