Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: streaming decoder #1564

Merged
merged 9 commits into from
Jan 17, 2025
Merged

feat!: streaming decoder #1564

merged 9 commits into from
Jan 17, 2025

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Jan 6, 2025

Release notes

In this release, we:

  • Changed ABIDecoder methods to take std::io::Read instead of &[u8], allowing it to be used in a streaming manner.

Summary

ABIDecoder methods take bytes: impl std::io::Read instead of bytes: &[u8]. This allows decoding abi types without having to know the size in advance. This is particularly useful when reading them directly from VM memory, which will be used by the indexer after FuelLabs/fuel-core#2491 is done.

Breaking Changes

ABIDecoder methods take bytes: impl std::io::Read instead of bytes: &[u8]. Callers using arrays or Vec must change the argument from &value to value.as_slice().

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dentosal Dentosal changed the title Streaming decoder support Streaming decoder Jan 6, 2025
@hal3e hal3e changed the title Streaming decoder feat!: streaming decoder Jan 7, 2025
@Dentosal Dentosal enabled auto-merge (squash) January 15, 2025 16:13
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dentosal Dentosal merged commit 1570dc0 into master Jan 17, 2025
45 checks passed
@Dentosal Dentosal deleted the dento/streaming-decoder branch January 17, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants