Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add expiration transaction policy #1583

Merged
merged 12 commits into from
Feb 4, 2025
Merged

feat: add expiration transaction policy #1583

merged 12 commits into from
Feb 4, 2025

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jan 21, 2025 •
edited
Loading

closes: #1577

Release notes

Added the expiration transaction policy. Now the user can limit until which block height the transaction is valid.

Breaking Changes

  • added expiration: Option<u64> field to TxPolicies struct
  • Transaction trait method maturity now returns Option<u64>
  • Transaction trait method with_maturity is removed.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@hal3e hal3e added the enhancement New feature or request label Jan 21, 2025
@hal3e hal3e self-assigned this Jan 21, 2025
digorithm
digorithm previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat -- great tests!

MujkicA
MujkicA previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a remark about our general approach to testing.
PR looks good :shipit:

packages/fuels-core/src/types/wrappers/transaction.rs Show resolved Hide resolved
e2e/tests/predicates.rs Show resolved Hide resolved
@hal3e hal3e dismissed stale reviews from MujkicA and digorithm via 967e20b January 27, 2025 09:46
@hal3e hal3e requested review from digorithm and MujkicA January 27, 2025 09:47
segfault-magnet
segfault-magnet reviewed Feb 3, 2025
View reviewed changes
e2e/tests/contracts.rs Outdated Show resolved Hide resolved
e2e/tests/predicates.rs Outdated Show resolved Hide resolved
@hal3e hal3e requested a review from segfault-magnet February 3, 2025 10:49
@hal3e hal3e merged commit f2a7f27 into master Feb 4, 2025
45 checks passed
@hal3e hal3e deleted the hal3e/exiration-policy branch February 4, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salka1988 Salka1988 Salka1988 approved these changes

@MujkicA MujkicA MujkicA approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@hal3e hal3e

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new policies: Expiration and Owner
5 participants
@hal3e @digorithm @Salka1988 @MujkicA @segfault-magnet