-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dev:crx command of wallet not working in local env FE-866 #1639
Draft
arthurgeron
wants to merge
11
commits into
master
Choose a base branch
from
ag/fix/vite-dev-crx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurgeron
force-pushed
the
ag/fix/vite-dev-crx
branch
from
October 28, 2024 20:02
8ca9818
to
d86db8e
Compare
arthurgeron
force-pushed
the
ag/fix/vite-dev-crx
branch
from
October 28, 2024 20:10
d86db8e
to
548fa81
Compare
arthurgeron
force-pushed
the
ag/fix/vite-dev-crx
branch
from
October 28, 2024 21:00
548fa81
to
2733df7
Compare
arthurgeron
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco,
rodrigobranas and
nelitow
as code owners
October 28, 2024 21:10
arthurgeron
force-pushed
the
ag/fix/vite-dev-crx
branch
from
October 31, 2024 14:38
2170d27
to
13be98b
Compare
auto-merge was automatically disabled
November 6, 2024 06:13
Pull request was converted to draft
LuizAsFight
changed the title
fix: wallet not loading correctly in local env FE-866
fix: dev:crx command of wallet not working in local env FE-866
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FE-976
Fixes
use_dynamic_url
being set totrue
on local env, which breaks the extension load on Chrome 130+Upgraded vite to V5 and @crxjs to versions that fixes previously mentioned error
Due to Vite requirements, load.env was migrated to use ESM syntax and other adjustments were made in our tsconfig
Update biome patch version to 1.6.2, which fixes an issue when processing
.cts
files.Use multi-arch Fuel Core docker image