Suggest Code Style & Refactoring

src/gqlRules/gqlOperationName/gqlOperationName.js

@@ -1,4 +1,4 @@
-import { isGqlFile } from "../utils";
+import { isGqlFile, isGqlTemplateElement } from "../utils";
 import { isQuery, isMutation } from "../utils/isGQLOperation";
 import { relativePathToFile } from "../../utils";
 import { operationName } from "../utils/operationName";
@@ -37,10 +37,6 @@ const create = context => {
   const isGqlObjectFile = isGqlFile(context);
   const { namespaceOperationPrefix, namespaceIgnoreList } = context.options[0];
 
-  const isGqlTemplateElement = node => {
-    return node.tag && node.tag.name === "gql";
-  };
-
   const getNamespaceAndPrefix = () => {
     const pathToFile = relativePathToFile(context);
     const relativeJsPath = pathToFile.replace("app/javascript/", "");

src/gqlRules/gqlVariableNameMatch/gqlVariableNameMatch.js

@@ -1,4 +1,4 @@
-import { isGqlFile } from "../utils";
+import { isGqlFile, isGqlTemplateElement } from "../utils";
 import { isQuery } from "../utils/isGQLOperation";
 import { relativePathToFile } from "../../utils";
 import { operationName } from "../utils/operationName";
@@ -29,44 +29,35 @@ const meta = {
   ],
 };
 
-const create = context => {
-  const isGqlObjectFile = isGqlFile(context);
-  const { namespaceIgnoreList } = context.options[0];
-
-  const isGqlTemplateElement = node => {
-    return node.tag && node.tag.name === "gql";
-  };
-
-  const isInIgnoreList = () => {
-    const pathToFile = relativePathToFile(context);
-    return namespaceIgnoreList.some(ignoredNamespace => pathToFile.startsWith(ignoredNamespace));
-  };
-
-  const isOperationNameAndVariableNameSame = (gqlOperationText, node) => {
-    const operationType = isQuery(gqlOperationText) ? "Query" : "Mutation";
-    const gqlOperationName = operationName(gqlOperationText, operationType);
-    const { id } = node;
-    const variableName = id.name;
-    if (isInIgnoreList()) {
-      return;
-    }
+const isInIgnoreList = (ignoreList, pathToFile) =>
+  ignoreList.some(name => pathToFile.startsWith(name));
 
-    const isOperationNameValid = !!gqlOperationName.match(variableName);
+const isOperationNameAndVariableNameSame = (gqlOperationText, node) => {
+  const operationType = isQuery(gqlOperationText) ? "Query" : "Mutation";
+  const gqlOperationName = operationName(gqlOperationText, operationType);
+  const variableName = node.id.name;
+  return !!gqlOperationName.match(variableName);
+};
 
-    if (!isOperationNameValid) {
-      context.report({
-        node: node,
-        message: `The variable name "${variableName}" should match with the GQL operation name, please use "${gqlOperationName}"`,
-      });
-    }
-  };
+const create = context => {
+  const pathToFile = relativePathToFile(context);
+  const isGqlObjectFile = isGqlFile(context);
+  const [{ namespaceIgnoreList }] = context.options;
 
   const VariableDeclarator = node => {
-    if (!isGqlObjectFile || !isGqlTemplateElement(node.init)) return;
-    const { init } = node;
-    const templateElementNode = init.quasi;
+    if (!isGqlObjectFile) return;
+    if (!isGqlTemplateElement(node.init)) return;
+    if (isInIgnoreList(namespaceIgnoreList, pathToFile)) return;
+
+    const templateElementNode = node.init.quasi;
     const gqlOperationText = sanitizeGqlOperationText(templateElementNode, context);
-    isOperationNameAndVariableNameSame(gqlOperationText, node);
+    const isOperationNameValid = isOperationNameAndVariableNameSame(gqlOperationText, node);
+    if (isOperationNameValid) return;
+
+    context.report({
+      node: node,
+      message: `The variable name "${variableName}" should match with the GQL operation name, please use "${gqlOperationName}"`,
+    });
   };
 
   return {

src/gqlRules/utils/index.js

@@ -3,3 +3,4 @@ export * from "./isGqlFile";
 export * from "./isGQLOperation";
 export * from "./operationName";
 export * from "./sanitizeGqlOperationText";
+export * from "./isGqlTemplateElement";

src/gqlRules/utils/isGqlTemplateElement/index.js

@@ -0,0 +1 @@
+export { isGqlTemplateElement } from "./isGqlTemplateElement";

src/gqlRules/utils/isGqlTemplateElement/isGqlTemplateElement.js

@@ -0,0 +1,3 @@
+const isGqlTemplateElement = node => node.tag && node.tag.name === "gql";
+
+export { isGqlTemplateElement };