Skip to content

Allow clipboard access from the embed app #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

pipopotamasu
Copy link
Collaborator

@pipopotamasu pipopotamasu commented Jun 17, 2025

The embed app has features to access the clipboard, but the current iframe setting doesn't allow access. This PR will fix the issue

@pipopotamasu pipopotamasu changed the title allow clipboard access from the embed app ALlow clipboard access from the embed app Jun 17, 2025
@pipopotamasu pipopotamasu changed the title ALlow clipboard access from the embed app Allow clipboard access from the embed app Jun 17, 2025
@pipopotamasu pipopotamasu marked this pull request as ready for review June 17, 2025 15:38
Copy link

@fallenAfter fallenAfter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into clipboard-read. I saw mention that it needs to self when dealing with cross origin. Has this been tested in a cross origin integration?
https://hellodevworldblog.medium.com/error-when-copying-to-clipboard-from-iframe-dab0b5c5f310

@pipopotamasu
Copy link
Collaborator Author

pipopotamasu commented Jun 17, 2025

I looked into clipboard-read. I saw mention that it needs to self when dealing with cross origin. Has this been tested in a cross origin integration? https://hellodevworldblog.medium.com/error-when-copying-to-clipboard-from-iframe-dab0b5c5f310

Nice callout, let me prepare test envs

[Edited]

Confirmed that self keyword is not necessary needed even though it's cross-origin

Copy link

@fallenAfter fallenAfter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@brandonbay brandonbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pipopotamasu pipopotamasu merged commit e22306b into master Jun 18, 2025
3 checks passed
@pipopotamasu pipopotamasu deleted the allow-clipboard-access branch June 18, 2025 14:08
@fullscript-devops
Copy link
Collaborator

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants