-
Notifications
You must be signed in to change notification settings - Fork 1
Allow clipboard access from the embed app #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into clipboard-read. I saw mention that it needs to self when dealing with cross origin. Has this been tested in a cross origin integration?
https://hellodevworldblog.medium.com/error-when-copying-to-clipboard-from-iframe-dab0b5c5f310
Nice callout, let me prepare test envs [Edited] Confirmed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The embed app has features to access the clipboard, but the current iframe setting doesn't allow access. This PR will fix the issue