Opponent StrumlineNote Confirm Animation #2609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my first instinct / opinion is that i might prefer a more snappy hit confirm! although I will toss the before/after to mr phantomarcade for his visual brain review on it |
|
also gonna link to #2522 which is another PR that modifies behaviour of strum anims for the opponent |
EliteMasterEric
added
status: pending triage
lemz1
changed the title
EliteMasterEric
added
small
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
|
25 commits for 1 line of code to be changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr fixes the confirm hold timer, since the animation sometimes got cut off. its kind of hard to accurately explain what it fixes, so i suggest watching the before and after.
BEFORE:
before.mp4
AFTER:
after.mp4