Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]: Disable Screenshotting on HTML5 builds #3437

Closed
wants to merge 1 commit into from

Conversation

JVNpixels
Copy link
Contributor

@JVNpixels JVNpixels commented Sep 22, 2024

Does this PR close any issues? If so, link them below.

Unsure, when I searched "screenshots" it has nothing related to it most likely due to how the issue format is.

Briefly describe the issue(s) fixed.

On HTML5, when the player would take a screenshot, it would crash since there was no "screenshots" directory due to it not being a windows build.

Include any relevant screenshots or videos.

image

Note:

I was spamming the screenshot button in this video
I changed the key to 8 since F3 would interfere with my browser, no actual code is set for it to be defaulted to 8, it is still F3.
https://github.com/user-attachments/assets/f815a48d-7b9b-400a-b031-229d4a255cb2

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Sep 25, 2024
@EliteMasterEric
Copy link
Member

Already fixed internally

@EliteMasterEric EliteMasterEric added status: rejected Issue did not pass review or PR cannot be approved. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression and removed status: pending triage The bug or PR has not been reviewed yet. labels Sep 25, 2024
@JVNpixels
Copy link
Contributor Author

thats okay lol all i did was just type 2 lines of code 💀😭🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants