CharSelect polish #3439
Closed
CharSelect polish #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doggogit
approved these changes
Sep 23, 2024
#3355 already handles this, but everything else seems good. |
JVNpixels
approved these changes
Sep 23, 2024
EliteMasterEric
added
the
status: pending triage
|
some changes may have been fixed with #3457 although what was the specifics with the memory leak? |
Was refering to the slowdown when switching to a character for the first time since it has to load the full character atlas mid-frame, precaching characters on create fixes the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly describe the issue(s) fixed.
Fixed "duplicate" bf's when opening the char select screen.
Fixed memory leak at the unlock character sequence.
Fixed inputs being allowed at the unlock character sequence.
Fixed spam causing errors displaying the current character / nametag.
Made it remember your last selected character.
Optimized a bit by checking for changes only on key presses.
Include any relevant screenshots or videos.
Before
8mb.video-uor-jKOnXSzl.mp4
After
8mb.video-rG1-5FnA0AXU.mp4