Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[BUGFIX] Reset CWD before Preloader" #3538

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Revert "[BUGFIX] Reset CWD before Preloader" #3538

merged 1 commit into from
Oct 26, 2024

Conversation

NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Oct 2, 2024 •
edited
Loading

Reverts #2629 as it's not needed anymore due to Lime having patched this bug internally since 8.1.0

@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed size: small A small pull request with 10 or fewer changes. labels Oct 8, 2024
@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 991fb7b to 62db95f Compare October 8, 2024 20:12
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: documentation PR modifies documentation or README files. labels Oct 8, 2024
@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 62db95f to 1cfe5ad Compare October 8, 2024 20:13
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. size: large A large pull request with more than 100 changes. and removed size: large A large pull request with more than 100 changes. labels Oct 8, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 8, 2024

This is a large change.

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Oct 8, 2024 •
edited
Loading

More like smarge

This bot should probably also remove other tags as well lol and also only take into account changes made by the author of the PR.

@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 1cfe5ad to 5a80515 Compare October 12, 2024 00:22
@github-actions github-actions bot removed the size: large A large pull request with more than 100 changes. label Oct 12, 2024
@ninjamuffin99 ninjamuffin99 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 5a80515 to f2ba8dd Compare October 26, 2024 20:03
@ninjamuffin99 ninjamuffin99 merged commit e6b6b41 into FunkinCrew:develop Oct 26, 2024
2 checks passed
@NotHyper-474 NotHyper-474 deleted the revert-2629-bugfix/cwd-preloader-issue branch October 26, 2024 20:25
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: documentation Involves improvements or additions to documentation. pr: documentation PR modifies documentation or README files. and removed pr: documentation PR modifies documentation or README files. type: documentation Involves improvements or additions to documentation. labels Jan 22, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 23, 2025
@Hundrec Hundrec added the type: chore Involves minor adjustments that do not make functional changes. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
4 participants
@NotHyper-474 @Hundrec @EliteMasterEric @ninjamuffin99