Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BUGFIX] Reset CWD before Preloader" #3538

Conversation

NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Oct 2, 2024

Reverts #2629 as it's not needed anymore due to Lime having patched this bug internally since 8.1.0

@github-actions github-actions bot added small A small pull request with 10 or fewer changes haxe Issue/PR modifies game code and removed small A small pull request with 10 or fewer changes labels Oct 8, 2024
@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 991fb7b to 62db95f Compare October 8, 2024 20:12
@github-actions github-actions bot added large A large pull request with more than 100 changes documentation Issue/PR modifies documentation or README files labels Oct 8, 2024
@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 62db95f to 1cfe5ad Compare October 8, 2024 20:13
@github-actions github-actions bot added small A small pull request with 10 or fewer changes large A large pull request with more than 100 changes and removed large A large pull request with more than 100 changes labels Oct 8, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Oct 8, 2024

This is a large change.

@NotHyper-474
Copy link
Contributor Author

NotHyper-474 commented Oct 8, 2024

More like smarge

This bot should probably also remove other tags as well lol and also only take into account changes made by the author of the PR.

@NotHyper-474 NotHyper-474 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 1cfe5ad to 5a80515 Compare October 12, 2024 00:22
@github-actions github-actions bot removed the large A large pull request with more than 100 changes label Oct 12, 2024
@ninjamuffin99 ninjamuffin99 force-pushed the revert-2629-bugfix/cwd-preloader-issue branch from 5a80515 to f2ba8dd Compare October 26, 2024 20:03
@ninjamuffin99 ninjamuffin99 merged commit e6b6b41 into FunkinCrew:develop Oct 26, 2024
2 checks passed
@NotHyper-474 NotHyper-474 deleted the revert-2629-bugfix/cwd-preloader-issue branch October 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue/PR modifies documentation or README files haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants