Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now changing lists sends you to the same song #3902

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

amyspark-ng
Copy link
Contributor

@amyspark-ng amyspark-ng commented Nov 28, 2024

example: if you are in fav songs and you scroll to the "ALL" section it will now send you to the song you were hovering the favs section, opposed to sending you to the start of the list, which it did before
fixes: #3901

i was also trying to make it so it didn't restart the song preview but couldn't figure out how

also i don't know why it marks submodules as updated! i tried to discard and it wouldn't work sorry

@github-actions github-actions bot added haxe Issue/PR modifies game code documentation Issue/PR modifies documentation or README files large A large pull request with more than 100 changes labels Nov 28, 2024
@amyspark-ng amyspark-ng changed the base branch from main to develop November 28, 2024 04:49
@github-actions github-actions bot added medium A medium pull request with 100 or fewer changes and removed large A large pull request with more than 100 changes labels Nov 28, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Nov 28, 2024

Inspecting the existing comments, it looks like the devs intended for the song to land on the first song.
I'd treat your change as an enhancement that wouldn't necessarily be better in all cases.
While staying on the same song would be nice when accidentally switching letter sorts, it may confuse users when landing in the middle of the AB list, for example.
I think it would be worthwhile to give this change some consideration before merging.

Also, the submodules are different due to new commits since the last update.

@amyspark-ng
Copy link
Contributor Author

While staying on the same song would be nice when accidentally switching letter sorts, it may confuse users when landing in the middle of the AB list, for example.
I see what you mean, i could make changes so it doesn't work on letters sorts???? idk would have to see what devs think

Also i created branch from develop, how are there changes? wanted to see a way to revert but couldn't, do you know how?

@Hundrec
Copy link
Contributor

Hundrec commented Nov 28, 2024

It's just GitHub being silly
I think leaving it this way would be fine since Eric has magical merging powers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue/PR modifies documentation or README files haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants