[ENHANCEMENT/BUGFIX] Bopper sync and bpm change events #3903
+150
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bopper desyncing from each other, imitating the
if(curBeat % 2 == 0) dad.dance();
from the 0.3.X of the game, but calculate it automatically with the actual idle animation duration, usingdanceEvery
as a well, making it consistent with the BPM and camera bopping.For it to work, I also included
onBpmChange()
and thebpmChange
SongTimeScriptEvent
, called every time the bpm changes, allowing easier scripting instead of manually detecting it thoughbeatHit
if we use an.hxc
script.To do:
Find a way to handle the automation for a decimal
danceEvery
, currently ignored and works like before