Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT/BUGFIX] Bopper sync and bpm change events #3903

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MidyGamy
Copy link

@MidyGamy MidyGamy commented Nov 28, 2024

This fixes the bopper desyncing from each other, imitating the if(curBeat % 2 == 0) dad.dance(); from the 0.3.X of the game, but calculate it automatically with the actual idle animation duration, using danceEvery as a well, making it consistent with the BPM and camera bopping.

For it to work, I also included onBpmChange() and the bpmChange SongTimeScriptEvent, called every time the bpm changes, allowing easier scripting instead of manually detecting it though beatHit if we use an .hxc script.

To do:
Find a way to handle the automation for a decimal danceEvery, currently ignored and works like before

@github-actions github-actions bot added large A large pull request with more than 100 changes haxe Issue/PR modifies game code and removed large A large pull request with more than 100 changes labels Nov 28, 2024
@MidyGamy
Copy link
Author

MidyGamy commented Nov 28, 2024

Btw, this is a rewrite of #3092, which was broken and unorganized

@MidyGamy MidyGamy changed the title Bopper sync and bpm change events [ENHANCEMENT/BUGFIX] Bopper sync and bpm change events Nov 28, 2024
@github-actions github-actions bot added large A large pull request with more than 100 changes and removed large A large pull request with more than 100 changes labels Nov 28, 2024
@MidyGamy
Copy link
Author

Ok I might found a solution, but maybe a better looking one could be found?
(P.S. I don't even understand why decimal danceEvery is even a thing...)

@MidyGamy MidyGamy marked this pull request as ready for review November 28, 2024 22:51
@AbnormalPoof
Copy link
Contributor

(P.S. I don't even understand why decimal danceEvery is even a thing...)

#2925 (comment):

I will also change danceEvery so that it uses event.step % (danceEvery * STEPS_PER_BEAT) so it works with any multiple of 0.25

@MidyGamy
Copy link
Author

(P.S. I don't even understand why decimal danceEvery is even a thing...)

#2925 (comment):

I will also change danceEvery so that it uses event.step % (danceEvery * STEPS_PER_BEAT) so it works with any multiple of 0.25

Yeah... still confused...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants