issue-1589 #28
issue-1589 #28
Conversation
FusionAuth/fusionauth-issues#1589 Add link and unlink events
| UserIdentityProviderLink("user.idp.link"), | ||
|
|
||
| UserIdentityProviderUnlink("user.idp.unlink"), | ||
|
|
There was a problem hiding this comment.
- Please alphabetize these
- I wonder if we should spell out
idp- other events such asuser.two-factor.method.adduse the long form and mostly matches the Enum name. Would it be too long to douser.identity-provider.linkanduser.identity-provider.unlink?
| @@ -0,0 +1,53 @@ | |||
| /* | |||
| * Copyright (c) 2019-2022, FusionAuth, All Rights Reserved | |||
There was a problem hiding this comment.
This is a new class, should be 2022.
| * | ||
| * @author Rob Davis | ||
| */ | ||
| public class UserIdentityProviderLinkEvent extends BaseEvent implements Buildable<UserIdentityProviderLinkEvent>, NonTransactionalEvent { |
| public UserIdentityProviderLinkEvent() { | ||
| } | ||
|
|
||
| public UserIdentityProviderLinkEvent(EventInfo info, String identityProviderName, User user) { |
There was a problem hiding this comment.
It is fine if we add the name, but the event needs to for sure contain the IdP Id. It seems that we should also include details about the link itself. Should we be adding the entire link object? Or at least the IdP user unique Id, IdP user display name if we have it, the FusionAuth IdP link Id, etc. We need to assume someone wants to consume this event and then use it to create FKs, or call back to FusionAuth and be able to retrieve specific information.
| @@ -0,0 +1,53 @@ | |||
| /* | |||
| * Copyright (c) 2019-2022, FusionAuth, All Rights Reserved | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2018-2019, FusionAuth, All Rights Reserved | |||
| * Copyright (c) 2018-2022, FusionAuth, All Rights Reserved | |||
There was a problem hiding this comment.
Looks like we have the wrong copyright here, can you update this to the Apache license.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2018-2020, FusionAuth, All Rights Reserved | |||
| * Copyright (c) 2018-2022, FusionAuth, All Rights Reserved | |||
There was a problem hiding this comment.
Looks like we have the wrong copyright here, can you update this to the Apache license.
| * | ||
| * @author Rob Davis | ||
| */ | ||
| public class UserIdentityProviderUnlinkEvent extends BaseEvent implements Buildable<UserIdentityProviderUnlinkEvent>, NonTransactionalEvent { |
| public UserIdentityProviderUnlinkEvent() { | ||
| } | ||
|
|
||
| public UserIdentityProviderUnlinkEvent(EventInfo info, String identityProviderName, User user) { |
There was a problem hiding this comment.
Same comment form the link event, we should add more details to this event.
|
|
||
| @Override | ||
| public EventType getType() { | ||
| return EventType.UserIdentityProviderLink; |
FusionAuth/fusionauth-issues#1589 New Event Types for Identity Provider Link and Unlink
…oken for some tests. Fix method naming in LastLoginMapper. Add more tests. Add a test for end-to-end workflows for Device Grant and IdP linking with the new Link Events.
Add link and unlink events