Improving README and adding workflow to test the library #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcampitelli
changed the title
vcampitelli
changed the title
mooreds
reviewed
Feb 27, 2024
Co-authored-by: Dan Moore <[email protected]>
|
@mooreds I've fixed almost all of your suggestions, added some descriptions to the code examples and left some comments in your review. |
|
Did a 'pair PR review' at our 1:1 :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
READMEwith the new format and adds a GitHub Action to set up a FusionAuth instance and test the library against it.PS: this depends on #30 as I based my branch on it to leverage the PHP update