-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating "Testing Lambdas" to MDX #2705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get stuck with error message. Think I found out why. Was logged in to admin app and tried to log in as richard too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else worked well. It is just the login test that I am having issues with now.
test login returns JWT with "Goodbye World"
not ok 1 TypeError: login is not a function
---
operator: error
stack: |-
TypeError: login is not a function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a bit better. Still seeing some of the deprecation messages and got one error I had to fix, but I was able to get all the way through it with 6 tests passing.
@mark-robustelli I've pushed some changes and this is now ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, only 2 issues. 1) Still getting the deprecation warnings but I think you said we have to update the library to get rid of them so I think that is OK. 2) In the commands to install the testing framework I get errors from the copy and paste because of the comments. Please find another way to comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I found it easier to duplicate the branch from #2340 and fix things there as merging or rebasing were kind of complicated.
I've compared both articles a few times before opening this PR.