Pulling in latest fhaviary, mypy, ruff
#647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
sidnarayanan,
mskarlin and
nadolskit
dosubot
bot
added
the
size:L
jamesbraza
commented
Oct 25, 2024
| @@ -256,7 +256,7 @@ async def s2_title_search( | |||
| # need to check if nested under a 'data' key or not (depends on filtering) | |||
| if ( | |||
| strings_similarity( | |||
| data.get("title") if "data" not in data else data["data"][0]["title"], | |||
| data.get("title", "") if "data" not in data else data["data"][0]["title"], | |||
There was a problem hiding this comment.
@mskarlin FYI on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in the latest improvements from various upstream repos