Fixes gather_with_concurrency typing
#714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maykcaldas
commented
Nov 20, 2024
| @@ -650,7 +650,7 @@ async def aget_evidence( | |||
| for _, llm_result in results: | |||
| session.add_tokens(llm_result) | |||
|
|
|||
| session.contexts += [r for r, _ in results if r is not None] | |||
| session.contexts += [r for r, _ in results] | |||
There was a problem hiding this comment.
This is being discussed in #687. However, the typing change didn't fix the mypy error saying that r is not None is a always True statement
There was a problem hiding this comment.
Cannot do this I think. You can get a None back I believe
maykcaldas
commented
Nov 21, 2024
maykcaldas
changed the title
gather_with_concurrency typinggather_with_concurrency typing
dosubot
bot
added
the
size:M
jamesbraza
reviewed
Nov 23, 2024
There was a problem hiding this comment.
@maykcaldas looks like pydantic==2.10.1 is out, can you rebase or merge main for the updated uv.lock
…penAI connection error
jamesbraza
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type hint of
gather_with_concurrencyfromgather_with_concurrency(n: int, coros: list[Coroutine]) -> list[Any]:to
Also pinned pydantic version to <2.10 until they release the v2.10 bugfix.