Make compatible with Gradle 8 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code generated by
kspCommonMainMetadatafrom/build/generated/ksp/metadata/commonMain/kotlinwas being set as thesrcDirfor theiosMainsource set.However, this setup resulted in errors when using Gradle 8.
As a solution, I attempted to specify options like
kspIosArm64, but this led to aTypeMirrorerror, as documented in square/kotlinpoet#1273.In order to make koru compatible with Gradle 8, the following changes were made:
Xxx::classwithXxx::class.asTypeName()cba6d5a 21cad65kspCommonMainMetadatawith theCompilerPluginand instead retrieved Apple-related configurations from the configurations and set them accordingly. 7a05ff7