Refreshing the page after a finished validation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsne
approved these changes
Jun 30, 2022
mpsonntag
requested changes
Jun 30, 2022
mpsonntag
reviewed
Jun 30, 2022
mpsonntag
reviewed
Jun 30, 2022
| @@ -0,0 +1,16 @@ | |||
| window.addEventListener("load", function(evt) { | |||
There was a problem hiding this comment.
Currently this is called on every page; the execution should be restricted to the results page if results are still unavailable.
There was a problem hiding this comment.
Opened issue #97
Pull Request Test Coverage Report for Build 2590904807
💛 - Coveralls |
Page will be refreshed after a validation will be done
mpsonntag
requested changes
Jun 30, 2022
| new_uri = "ws:"; | ||
| } | ||
| new_uri += "//" + loc.host + "/ws"; | ||
| ws = new WebSocket(new_uri); |
There was a problem hiding this comment.
Just tested it on valid.dev.g-node.org, where it fails here with the browser console message WebSocket connection to 'wss://valid.dev.g-node.org/ws' failed.
|
The changes are kept in a separate branch; I'll change the PR status to draft until the required changes can be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page will be refreshed automatically after a validation will be done.
The user will see a loading animation to make him more comfortable to wait