Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial sync using fullstatedump API #322

Merged
merged 4 commits into from
Nov 15, 2024
Merged

initial sync using fullstatedump API #322

merged 4 commits into from
Nov 15, 2024

Conversation

sudiptob2
Copy link
Collaborator

closes #288

@sudiptob2 sudiptob2 force-pushed the feat/288/use-fullstate-dump branch from 93b2348 to 89dfe82 Compare November 5, 2024 04:49
@sudiptob2 sudiptob2 changed the title Feat/288/use fullstate dump initial sync using fullstatedump API Nov 5, 2024
@sudiptob2 sudiptob2 marked this pull request as ready for review November 6, 2024 14:57
nikola-jokic
nikola-jokic requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote few questions ☺️ Overall looks good

internal/yunikorn/rest.go Outdated Show resolved Hide resolved
internal/yunikorn/sync.go Outdated Show resolved Hide resolved
internal/yunikorn/sync.go Outdated Show resolved Hide resolved
@sudiptob2 sudiptob2 force-pushed the feat/288/use-fullstate-dump branch from 4a75bdb to b91b2da Compare November 6, 2024 18:18
@sudiptob2 sudiptob2 force-pushed the feat/288/use-fullstate-dump branch 3 times, most recently from e71e53c to dd66a19 Compare November 8, 2024 14:24
@sudiptob2 sudiptob2 self-assigned this Nov 8, 2024
@sudiptob2 sudiptob2 force-pushed the feat/288/use-fullstate-dump branch from b89ab2b to cbd8450 Compare November 9, 2024 21:27
nikola-jokic
nikola-jokic requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes before we are done with this change ☺️

internal/yunikorn/accumulator.go Outdated Show resolved Hide resolved
internal/yunikorn/event_handler.go Outdated Show resolved Hide resolved
richscott
richscott previously approved these changes Nov 13, 2024
View reviewed changes
richscott
richscott approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@richscott richscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sudiptob2 sudiptob2 force-pushed the feat/288/use-fullstate-dump branch from 27e5694 to c120b5a Compare November 15, 2024 15:37
@richscott richscott merged commit b4894b3 into G-Research:main Nov 15, 2024
9 checks passed
@sudiptob2 sudiptob2 deleted the feat/288/use-fullstate-dump branch November 15, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-jokic nikola-jokic nikola-jokic approved these changes

@richscott richscott richscott approved these changes

Assignees

@sudiptob2 sudiptob2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source state before the event handler takes place
3 participants
@sudiptob2 @richscott @nikola-jokic