implement testsuite and test-containers for repository integration test #332
Conversation
|
|
||
| func (ns *NodeTestSuite) SetupSuite() { |
There was a problem hiding this comment.
Do we want to run many test suites? Isn't it better to have a single db instance and maybe, if we really need to do it, create different databases?
There was a problem hiding this comment.
Thanks. I thought creating multiple db containers would help to run the tests in parallel. But the idea of creating multiple db in a single container sounds good.
There was a problem hiding this comment.
Creating db instances in Postgres is very fast, definitely quicker than instantiating a container.
There was a problem hiding this comment.
updated with separate DB instead of separate container
sudiptob2
force-pushed
the
feat/82/setup-testsuit
branch
from
21a0821 to
9e175d5
Compare
test/database/postgres.go
Outdated
| Password string | ||
| DBName string | ||
| Host string | ||
| Port string |
There was a problem hiding this comment.
What do you think about making this an int instead of a string, for a little more type-safety?
sudiptob2
force-pushed
the
feat/82/setup-testsuit
branch
from
bbaf8f4 to
4e6a31d
Compare
closes #82