Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denis coric/prod env #404

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Denis coric/prod env #404

merged 6 commits into from
Jan 22, 2025

Conversation

dcoric
Copy link
Collaborator

@dcoric dcoric commented Jan 22, 2025

This pull request is altering how UHS & YK Web use environment configuration.

  • If production is active on build-time, both web apps will use information from the current window (path and port) to target the UHS API directly
  • Override is still possible for development purposes (production flag set to false)

This change aims to remove hardcoded dependencies and paths on UHS/YK Web and allow deployment flexibility.

@dcoric dcoric requested a review from sudiptob2 January 22, 2025 14:23
sudiptob2
sudiptob2 previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudiptob2 sudiptob2 self-requested a review January 22, 2025 14:44
@dcoric dcoric merged commit d45fc18 into main Jan 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoric @sudiptob2