feat : Implement board delete API #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangjokim
commented
Nov 5, 2024
| @@ -3,10 +3,10 @@ | |||
| import lombok.Getter; | |||
|
|
|||
| @Getter | |||
| public class BoardValidationExceoption extends RuntimeException { | |||
| public class BoardValidationException extends RuntimeException { | |||
There was a problem hiding this comment.
์ด๊ฑด ์คํ์๊ธธ๋ ๊ฑฐ์ฌ๋ ค์ ๊ณ ์ณค์ด์.
|
์๊ฐ ๋๋ฉ์ธ ์ด๋ฆ๋ณ๊ฒฝ ๋ธ๋กํนํด์, ์ฐ์ ์์ ๋์ฌ์ฃผ์๋ฉด ใฑใ |
rladmstn
approved these changes
Nov 5, 2024
|
|
||
| import com.gamzabat.algohub.feature.board.domain.Board; | ||
| import com.gamzabat.algohub.feature.board.domain.BoardComment; | ||
|
|
||
| public interface BoardCommentRepository extends JpaRepository<BoardComment, Long> { | ||
|
|
||
| List<BoardComment> findAllByBoard(Board board); | ||
|
|
||
| @Modifying |
There was a problem hiding this comment.
์๋ ๋ญ๊ฐ์?? ์ฒ์๋ด
There was a problem hiding this comment.
1์ฐจ์บ์ ๋ ๋ ค์ฃผ๋ ์ด๋
ธํ
์ด์
์ด์์. ์ ๊ฑฐ ์ํ๋ฉด 1์ฐจ์บ์ ๋จ์์, findByIdํ๋ฉด ์ ๋ น ํ์ด๋์ด
์ ํํ๋ ์ ์ฟผ๋ฆฌ ์คํ ์งํ ๋ ๋ ค์ค๋๋ค./
s-hwan
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
close #145
๐ Description
๐ข Review Point
delete from BoardComment where id = ?ํํ๊ฐ ๋๊ธ ์๋งํผ ๋ฐ๋ณตํด์ ๋๊ฐ.. ์ด๊ฑฐ์ซ์ด์ ๊ทธ๋ฅ Batch delete query ์งฐ์ด์.๐Etc (์ ํ)
ํตํฉํ ์คํธ ์ํ๋๋ฐ ๋์ํ๋ค๊ณ ๋ด ๋ง์์ด ๋ณด์ฅํจ
๋ฆฌ๋ทฐ๋ฐ๊ณ ๋จธ์ง์ ํ ์คํธํ ๊ฒ์