Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : rename board to notice #148

Merged
merged 3 commits into from
Nov 5, 2024
Merged

refactor : rename board to notice #148

merged 3 commits into from
Nov 5, 2024

Conversation

hwangjokim
Copy link
Contributor

@hwangjokim hwangjokim commented Nov 5, 2024 •
edited
Loading

๐Ÿ“Œ Related Issue

close #137

๐Ÿš€ Description

  • board๋ฅผ ๋ชจ๋‘ notice๋กœ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ข Review Point

  • ๋†“์นœ๊ฑฐ ์—†์„๋“ฏ?
  • ์—”๋“œํฌ์ธํŠธ ๋ฐ”๊พธ๋Š”๊ฑฐ ๋งž์ฃ ?
  • ์ด๊ฑฐ ๋จธ์ง€๋˜๋ฉด ๋ฆด๋ฆฌ์ฆˆ ๋””๋น„ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ํ•ด์•ผ๋จ

๐Ÿ“šEtc (์„ ํƒ)

  • ๊ฐœ๋…ธ๊ฐ€๋‹ค๋ผ์„œ ํ•˜๋‹ค๊ฐ€ ํ›„ํšŒํ•จ

@hwangjokim hwangjokim added the refactoring ๋ฆฌํŒฉํ† ๋ง label Nov 5, 2024
@hwangjokim hwangjokim self-assigned this Nov 5, 2024
hwangjokim
hwangjokim commented Nov 5, 2024
View reviewed changes
build.gradle
@@ -60,6 +60,11 @@ dependencies {
// Redis
implementation 'org.springframework.boot:spring-boot-starter-data-redis'
}

clean {
delete file('src/main/generated')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ QueryDSL ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๊ฐ€ ๋‚ด๋ถ€์ ์œผ๋กœ QClass๋ผ๋Š”๊ฑธ ๋งŒ๋“œ๋Š”๋ฐ, ๋ณด๋“œ์— ๋Œ€ํ•ด ๊ธฐ์–ตํ•˜๊ณ  ์žˆ์„๊ฑฐ๋ผ ์ถ”๊ฐ€ํ–ˆ์–ด์š”. gradle clean ํ•œ๋ฒˆ์”ฉ ๋Œ๋ฆผ ๋ ๋“ฏ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ฑฐ ๋นŒ๋“œ ํ•œ ๋ฒˆ ๋Œ๋ฆฌ๋ฉด ์ž๋™์œผ๋กœ ์‹น ๋ฐ”๋€Œ์ง€ ์•Š๋‚˜์š”?? ์ „์— ๋จผ๊ฐ€ ๊ทธ๋žฌ๋˜ ๊ธฐ์–ต์ด ์žˆ๋Š” ๊ฒƒ ๊ฐ™์€๋””

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„๊ทธ๋ž˜์š”? ๋ป˜์ง“ํ–ˆ๋„ค

s-hwan
s-hwan approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@s-hwan s-hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ๋ง™์Šต๋‹ˆ๋‹ค...ใ… ใ…œใ… ใ…œ

rladmstn
rladmstn approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@rladmstn rladmstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋Œ€๋‹จํ•˜์‹œ๋„ค์š” ์ด ๋…ธ๊ฐ€๋‹ค๋ฅผ ํ•ด๋‚ด๋‹ค๋‹ˆ
๋ฏฟ๊ฒ ์Šต๋‹ˆ๋‹ค

@rladmstn
Copy link
Contributor

rladmstn commented Nov 5, 2024

์ด๊ฑฐ ์ƒํ˜์‹œ ์•„์ง ์•ˆ๋ดค๋Š”๋ฐ ๋จธ์ง€ํ•ด๋„ ๋˜๋‚˜์š”?
๋„ค์ด๋ฐ ๋ฆฌํŒฉํ† ๋ง์ด๊ธฐ๋„ ํ•˜๊ณ  ์ € ์ด๊ฑฐ ๋จธ์ง€๋ผ์•ผ ์ž‘์—… ๊ฐ€๋Šฅํ•ด์„œ์š”

@hwangjokim
Copy link
Contributor Author

hwangjokim commented Nov 5, 2024 •
edited
Loading

@rladmstn @s-hwan ์นดํ…Œ๊ณ ๋ฆฌ ๊ฑ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•ด๋ฒ„๋ ธ์–ด์š”.. ๊ทธ๊ฒƒํ•œ ํ•œ๋ฒˆ ๊ฐ€๋ณ๊ฒŒ ๋‹ค์‹œ ๋ด์ฃผ์„ธ์š”
์•„ ์•„๋‹ˆ๋‹ค ์ชผ๊ฐœ์„œ๊ฐ ใ„ฑใ„ท ๋ฆฌ๋ฒ„ํŠธํ• ๊ฒŒ์š”

@rladmstn
Copy link
Contributor

rladmstn commented Nov 5, 2024

@rladmstn @s-hwan ์นดํ…Œ๊ณ ๋ฆฌ ๊ฑ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•ด๋ฒ„๋ ธ์–ด์š”.. ๊ทธ๊ฒƒํ•œ ํ•œ๋ฒˆ ๊ฐ€๋ณ๊ฒŒ ๋‹ค์‹œ ๋ด์ฃผ์„ธ์š” ์•„ ์•„๋‹ˆ๋‹ค ์ชผ๊ฐœ์„œ๊ฐ ใ„ฑใ„ท ๋ฆฌ๋ฒ„ํŠธํ• ๊ฒŒ์š”

?! ๋ฐฉ๊ธˆ๋ง‰ ํ™•์ธํ•˜๊ณ  ์™”๋Š”๋ฐ

@hwangjokim hwangjokim merged commit af89f68 into develop Nov 5, 2024
1 check passed
@hwangjokim hwangjokim mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladmstn rladmstn rladmstn approved these changes

@s-hwan s-hwan s-hwan approved these changes

@sh0723 sh0723 Awaiting requested review from sh0723

Assignees

@hwangjokim hwangjokim

Labels
refactoring ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
3 participants
@hwangjokim @rladmstn @s-hwan