feat : 다른 유저 정보 조회 API 추가 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rladmstn
requested changes
Nov 11, 2024
| @@ -167,4 +167,12 @@ public ResponseEntity<Void> editStudyGroupVisibility(@AuthedUser User user, | |||
| studyGroupService.editStudyGroupVisibility(user, request); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "other-user-group_list") | |||
There was a problem hiding this comment.
엔드포인트에 이상한 언더바가 끼워져있어요..!
그리고 이 부분은 @PathVariable을 사용하는게 더 좋아보여요! 모르신다면 찾아보길 권장드립니다
Github도 url 보면 사용자 닉네임 들어가듯이 /api/{userId}/group 뭐 이런식으로 쓰이는건데 이 API에서는 이런식의 엔드포인트가 더 적절하지 않을까 싶습니담
| @@ -167,4 +167,12 @@ public ResponseEntity<Void> editStudyGroupVisibility(@AuthedUser User user, | |||
| studyGroupService.editStudyGroupVisibility(user, request); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "other-user-group_list") | |||
| @Operation(summary = "그룹 목록 조회 API", description = "방장 여부 상관 없이 유저가 참여하고 있는 그룹 모두 조회") | |||
There was a problem hiding this comment.
[nit] Swagger summary가 위에 현재 유저의 그룹 목록 조회랑 겹칩니다.
로직상 문제는 없지만 프론트 배려를 위해 더 정확한 메세지로 명시해줍시다!
| @@ -432,4 +432,47 @@ public void editStudyGroupVisibility(User user, EditGroupVisibilityRequest reque | |||
| member.updateVisibility(request.isVisible()); | |||
| log.info("success to update group visibility ( userId : {} )", user.getId()); | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public GetStudyGroupListsResponse getOtherStudyGroupList(Long targetUserId) { | |||
There was a problem hiding this comment.
이거 뭔가 내 그룹 목록 조회 메소드랑 중복이 많아서 조회 메소드를 하나로 빼서 재사용하는 리팩토링 할 수 있을 것 같은데..
hwangjokim
reviewed
Nov 13, 2024
build.gradle
Outdated
Comment on lines
62
to
64
| // QueryDSL | ||
| implementation 'com.querydsl:querydsl-jpa:5.0.0:jakarta' | ||
| annotationProcessor "com.querydsl:querydsl-apt:5.0.0:jakarta" |
There was a problem hiding this comment.
QueryDSL 이미 바로 위쪽에 선언되어있어요
| @@ -167,4 +167,12 @@ public ResponseEntity<Void> editStudyGroupVisibility(@AuthedUser User user, | |||
| studyGroupService.editStudyGroupVisibility(user, request); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "other-user-group_list") | |||
There was a problem hiding this comment.
underscore(_) 말고 dash(-)로 써주세요. 혼용되어있어요
| @@ -167,4 +167,12 @@ public ResponseEntity<Void> editStudyGroupVisibility(@AuthedUser User user, | |||
| studyGroupService.editStudyGroupVisibility(user, request); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "other-user-group_list") | |||
| @Operation(summary = "그룹 목록 조회 API", description = "방장 여부 상관 없이 유저가 참여하고 있는 그룹 모두 조회") | |||
There was a problem hiding this comment.
operation 설명이 list랑 완전히 동일한데, 수정해주세요
|
|
||
| @GetMapping(value = "otheruser-info") | ||
| @Operation(summary = "타회원정보조회 API") | ||
| public ResponseEntity<UserInfoResponse> OtherUserInfo(@AuthedUser User user, @RequestParam Long targetUserId) { |
|
피드백 다 반영했슴다~ |
rladmstn
reviewed
Nov 13, 2024
| @@ -127,4 +127,11 @@ public ResponseEntity<Void> checkNickname(@RequestParam String nickname) { | |||
| userService.checkNickname(nickname); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "otheruser-info") | |||
There was a problem hiding this comment.
얘도 PathVariable 사용하면 더 좋을 것 같아요-!
| @@ -167,4 +167,12 @@ public ResponseEntity<Void> editStudyGroupVisibility(@AuthedUser User user, | |||
| studyGroupService.editStudyGroupVisibility(user, request); | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "/{targetUserId}/list") | |||
|
다시 반영 해 놨슴다~! |
hwangjokim
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
#152
🚀 Description
📢 Review Point
📚Etc (선택)